-
Notifications
You must be signed in to change notification settings - Fork 114
feat: cuda gpu skeleton #5936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: cuda gpu skeleton #5936
Conversation
a5654c2 to
92b7093
Compare
CodSpeed Performance ReportMerging this PR will degrade performance by 40.62%Comparing Summary
Performance Changes
|
92b7093 to
d0914ee
Compare
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vortex-cuda/src/lib.rs
Outdated
| // Register CUDA kernel implementations for supported array encodings. | ||
| // | ||
| // session.register(BitPackedVTable::ID, &bitpacking::CUDA_SUPPORT); | ||
| // session.register(RLEVTable::ID, &rle::CUDA_SUPPORT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yaeh
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
9e176c3 to
75f3e0b
Compare
Signed-off-by: Alexander Droste <[email protected]>
75f3e0b to
9031f5c
Compare
Signed-off-by: Alexander Droste <[email protected]>
6a8c594 to
03b7d73
Compare
| session: Arc<CudaSession>, | ||
| array_ctx: vortex_array::ExecutionCtx, | ||
| ) -> VortexResult<Self> { | ||
| let stream = context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new should do no work. The CudaSession should hold the CudaContext, and CudaSession::new_execution_ctx() should create the stream
Provides the initial skeleton to register and run CUDA kernels.
Note that
cudarcdoes not need to be compiled conditionally as we defer symbol loading viadynamic-loadingsuch thatvortex-cudacan also be compiled on macOS.