Add dynamic CRD creation#4
Open
mikeshootzz wants to merge 2 commits into
Open
Conversation
This automatically creates a CRD based on XRDs under the appslap.io API group
mikeshootzz
requested review from
a team,
Kidswiss,
TheBigLee,
bastjan,
mdnix and
zugao
and removed request for
a team
2 tasks
Kidswiss
approved these changes
Jun 19, 2026
| xrd := &unstructured.Unstructured{} | ||
| xrd.SetGroupVersionKind(xrdGVK) | ||
| return ctrl.NewControllerManagedBy(mgr). | ||
| For(xrd). |
There was a problem hiding this comment.
We could already filter here for the claimGroup via a predicate.
But in reality won't probably matter, since the amount of XRDs is probably pretty small per cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This dynamically creates a claim CRD based on an XRD created in the appslap.io API group. The claim CRD has an owner reference towards the XRD and gets garbage collected automatically once it's removed.
Checklist