refactor(language-core): rewrite a subset of template node transforms #5769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
@vue/language-service
vue-tsc
@vue/typescript-plugin
commit: |
KazariEX
force-pushed
the
refactor/transforms
branch
from
2df73c5 to
ec9da65
Compare
serkodev
reviewed
Nov 27, 2025
| <div v-else-if="cond1.length"></div> | ||
|
|
||
| <template #default v-if="cond1 === true">1</template> | ||
| <template #default v-else-if="cond1.length">2</template> |
Collaborator
There was a problem hiding this comment.
the fixture of v-else-if="cond1.length" is for checking type narrowing
Member
Author
There was a problem hiding this comment.
If the combination of v-slot and v-if is no longer a special case, we should no need to repeat existing test cases for type narrowing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4539, fix #5492, fix vuejs/core#12258, close #5765
This change simplifies the transforms of the template AST, in particular by removing all
codegenNodethat existed only for runtime codegen purpose. This also results in an AST shape that is more favorable for language tools integration.