bond: T8084: disallow bond members that do not support MAC changes #4911
+52
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-po
added
bp/sagitta
|
👍 |
…g.Section Aggregated / bonded interfaces do only work with ethernet interfaces as underlaying link. There is no need to "dynamically" detect that eth0, eth1 or any other interface starting with eth is an ethernet interface. Remove calls to vyos.ifconfig.Section().
Consolidate repeated helper function calls used for both bonded and non-bonded Ethernet interfaces, resulting in cleaner and more maintainable code.
Add a safeguard to block MAC address changes when the underlying driver is ENA (used on AWS EC2), and display a clear error message instead of raising "OSError: [Errno 95] Operation not supported."
Building on commit ba60266 (“ethernet: T8084: prevent MAC changes on ENA interfaces (AWS EC2)”), add safeguards to prevent interfaces from being used as bond members if they: * do not support MAC address changes, or * appear on a denylist of interfaces invalid for bonding (currently empty)
Contributor
|
Tested on aws t3.medim instance (ena driver): aws c4.2xlarge instance (ixgbevf driver): |
|
CI integration 👍 passed! Details
|
sever-sever
approved these changes
Dec 22, 2025
Member
sever-sever
left a comment
sever-sever
left a comment
There was a problem hiding this comment.
Add list of unsupported ethernet drivers for interface bonding to avoid errors.
If and interface cannot change its own MAC address, assume it is. not bondable.
natali-rs1985
approved these changes
Dec 23, 2025
Contributor
natali-rs1985
left a comment
natali-rs1985
left a comment
There was a problem hiding this comment.
Disallows adding bond members that don't support MAC address changes - helps prevent bonding issues
vyosbot
added
mirror-initiated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
This commit series hardens bonding support and simplifies related code.
It prevents interfaces from joining a bond if they cannot change MAC addresses, including explicit handling for ENA interfaces on AWS EC2 with clear error messages instead of generic failures. It also refactors bond verification to remove duplicated logic and drops dynamic interface type detection, simplifying the code by assuming Ethernet-only bond underlays.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
virtio_netdriver to the list of disallwoed drivers and errors got emitted.Checklist: