-
Notifications
You must be signed in to change notification settings - Fork 23
Fix test on windows #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Fix test on windows #1431
Conversation
|
So, I'm pretty sure this will fix the main test problem, but ran into another underneath it when trying to debug: not sure what any of this means just yet, just posting it here as an update. Also of note, the runner completely locks up here, doing nothing until I ctrl+c - and it leaves two backgrounded node processes running and never quits them - meaning I have to manually kill the processes of node afterward to run the test again |
I haven't been able to verify this works because I've been running the consistency report, and some node process is bound to the test http port that I can't
killallwithout testing... However... I think we might want to add windows to the github PR testing as well to ensure future similar problems don't sneak in because no one tests it. These problems are usually really easy to fix when they happen.