Android Results Capture Prototype #1433
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/resources/commandsV2.json
* whitelist additional commands * spike on ADB proxy functionality * Spike with working utterance collection via stream * Cleanup, finalize * Setup env variables and remove unused shell scripts * Updates config-sandbox's REACT_APP_EXTERNAL_HOST to aria-at-app-sandbox.bocoup.com * General cleanup of original PR * Summary of changes: * There'll be a need to expose the local proxy out to the internet to get a public URL for this prototype to work as it should (eg. using ngrok or similar) * This supports having users having their own specific proxies * Adds a field to the TestRenderer for a user to provide that public url * Continue using the originally intended debug window on TestRenderer to be an output area that utterances can be copied from to avoid any clipboard management issues * TODOs and many logging messages added * Bundle ngrok into the adb-proxy build process * Additional support for running proxy and adb on windows from built resources * Simplify proxy auto detection * Prefer localtunnel over ngrok to avoid unneeded account creation * Misc * Conditionally include ngrok and build start adb server on server script start * Re-save proxy url on auto-detect * Focus on copy utterances button when utterances process is completed * Announce the clipboard copy happen * Update android testing device section notes * Additional feedback after selecting the open on android button * Better sanitize of output * Don't end start script on fatal error * Allow waking screen if needed * Remove unnecessary fetch to /proxy-url * Add zip files creation to build process * Preserve history of utterances * Remove get-network-ip.js * Standardize auto detect proxy status colors * Only show Android Device Testing section when the at.key is talkback_android --------- Co-authored-by: Howard Edwards <[email protected]>
# Conflicts: # client/components/TestQueue/index.jsx # client/components/TestRenderer/index.jsx # server/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work here is not expected to be merged in and should not be considered stable. This is to facilitate discussions on going forward with this capturing android results.
This work is available on the sandbox environment. View the wiki on this work for any supporting documentation.