-
Notifications
You must be signed in to change notification settings - Fork 23
fix: page query response time reduction and server load improvements #1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
| JSON.stringify(testPlanVersionPhases), | ||
| millisecondsUntilStale: 30000 | ||
| }); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testPlans is huge. Even a 30s staleWhileRevalidate() helps a bunch
ChrisC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stalgiag I just pulled this down locally and confirmed that all of the main pages are still loading. Everything does seem snappier and I think I'm seeing similar lighthouse scores as you reported (~60 on the test queue). The plan in the PR description makes sense to me.
Would leaning more on the apollo cache interfere with updates to the test queue in any way? (I'm thinking when testers get re-assigned, stats get updated, items getting added/removed to the queue, etc)
|
Yeah that is a place where this could definitely introduce issues. I've been manually testing and fixing any issues that I see with the cache not busting. I don't currently see any issues but ofc there are limits to my testing |
Overview
This PR is focused on improving load speed and responsiveness, with particular attention to the Test Queue page. These changes aim to reduce initial page load times, eliminate duplicate network requests, and improve perceived responsiveness through caching and progressive data fetching strategies.
Changes
TEST_QUEUE_PAGE_QUERY: Lightweight initial query fetching only essential fieldsTEST_QUEUE_EXPANDED_ROW_QUERY: Detailed data fetched on-demand when rows are expandedcache-firstnextFetchPolicy: 'cache-first'to all queries to prevent automatic refetchingkeyFieldsconfigurationdraftTestPlanRunsfrom DataManagement query (large nested data)totalScenarioCountresolver for efficient scenario countingNotes
TestQueue.test.jstest due to my bad mocking skills. The only thing this does is introduce some annoying logs into our test runs. I will try to clean up the mock before this makes it to mergingReview
I highly recommend that this be manually tested thoroughly. Ideally it could make it onto a deployed environment prior to merge (sandbox?) so that we can evaluate performance changes in that setting. Also, the webpack changes have not been thoroughly tested with build/deploy.