fix: ARIA and HTML feature reports are errantly combined and incorrectly named in the first column of the top-level report page #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
changed the base branch from
development
to
support-dynamic-title-for-references
howard-e
commented
Nov 5, 2025
| "checkbox": { "author": { "refId": "author", "type": "metadata", "value": "Isabel Del Castillo", "linkText": "" }, "authorEmail": { "refId": "authorEmail", "type": "metadata", "value": "[email protected]", "linkText": "" }, "title": { "refId": "title", "type": "metadata", "value": "Checkbox Example (Two State)", "linkText": "" }, "reference": { "refId": "reference", "type": "metadata", "value": "reference/2025-10-2_121011/checkbox.html", "linkText": "Test Case Page for Checkbox Example (Two State)" }, "designPattern": { "refId": "designPattern", "type": "metadata", "value": "https://www.w3.org/WAI/ARIA/apg/patterns/checkbox/", "linkText": "APG Pattern: Checkbox" }, "example": { "refId": "example", "type": "metadata", "value": "https://www.w3.org/WAI/ARIA/apg/patterns/checkbox/examples/checkbox/", "linkText": "APG Example: Checkbox Example (Two State)" }, "aria-checked": { "refId": "aria-checked", "type": "aria", "value": "aria-checked", "linkText": "aria-checked" }, "checkbox": { "refId": "checkbox", "type": "aria", "value": "Checkbox", "linkText": "checkbox" }, "group": { "refId": "group", "type": "aria", "value": "group", "linkText": "group" }, "aria-labelledby": { "refId": "aria-labelledby", "type": "aria", "value": "aria-labelledby", "linkText": "aria-labelledby" }, "list": { "refId": "list", "type": "htmlAam", "value": "list", "linkText": "list" } }, | ||
| "command-button": { "author": { "refId": "author", "type": "metadata", "value": "Isabel Del Castillo", "linkText": "" }, "authorEmail": { "refId": "authorEmail", "type": "metadata", "value": "[email protected]", "linkText": "" }, "title": { "refId": "title", "type": "metadata", "value": "Command Button Example", "linkText": "" }, "reference": { "refId": "reference", "type": "metadata", "value": "reference/2022-4-8_124112/button.html", "linkText": "Test Case Page for Command Button Example" }, "designPattern": { "refId": "designPattern", "type": "metadata", "value": "https://www.w3.org/WAI/ARIA/apg/patterns/button/", "linkText": "APG Pattern: Button" }, "example": { "refId": "example", "type": "metadata", "value": "https://www.w3.org/WAI/ARIA/apg/patterns/button/examples/button/", "linkText": "APG Example: Button" }, "button": { "refId": "button", "type": "aria", "value": "button", "linkText": "button" } }, | ||
| "disclosure-faq": { "author": { "refId": "author", "type": "metadata", "value": "James Scholes", "linkText": "" }, "authorEmail": { "refId": "authorEmail", "type": "metadata", "value": "[email protected]", "linkText": "" }, "title": { "refId": "title", "type": "metadata", "value": "Disclosure of Answers to Frequently Asked Questions Example", "linkText": "" }, "reference": { "refId": "reference", "type": "metadata", "value": "reference/2025-8-8_7334/disclosure-faq.html", "linkText": "Test Case Page for Disclosure of Answers to Frequently Asked Questions Example" }, "designPattern": { "refId": "designPattern", "type": "metadata", "value": "https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/", "linkText": "APG Pattern: Disclosure (Show/Hide)" }, "example": { "refId": "example", "type": "metadata", "value": "https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/examples/disclosure-faq/", "linkText": "APG Example: Disclosure (Show/Hide) for Answers to Frequently Asked Questions" }, "aria-expanded": { "refId": "aria-expanded", "type": "aria", "value": "aria-expanded", "linkText": "aria-expanded" }, "button": { "refId": "button", "type": "htmlAam", "value": "button", "linkText": "button" }, "div": { "refId": "div", "type": "htmlAam", "value": "div", "linkText": "div" }, "ul": { "refId": "ul", "type": "htmlAam", "value": "ul", "linkText": "ul" } }, | ||
| "disclosure-faq": { "author": { "refId": "author", "type": "metadata", "value": "James Scholes", "linkText": "" }, "authorEmail": { "refId": "authorEmail", "type": "metadata", "value": "[email protected]", "linkText": "" }, "title": { "refId": "title", "type": "metadata", "value": "Disclosure of Answers to Frequently Asked Questions Example", "linkText": "" }, "reference": { "refId": "reference", "type": "metadata", "value": "reference/2025-8-8_7334/disclosure-faq.html", "linkText": "Test Case Page for Disclosure of Answers to Frequently Asked Questions Example" }, "designPattern": { "refId": "designPattern", "type": "metadata", "value": "https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/", "linkText": "APG Pattern: Disclosure (Show/Hide)" }, "example": { "refId": "example", "type": "metadata", "value": "https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/examples/disclosure-faq/", "linkText": "APG Example: Disclosure (Show/Hide) for Answers to Frequently Asked Questions" }, "aria-expanded": { "refId": "aria-expanded", "type": "aria", "value": "aria-expanded", "linkText": "aria-expanded" }, "button": { "refId": "button", "type": "htmlAam", "value": "button", "linkText": "button" }, "div": { "refId": "div", "type": "htmlAam", "value": "div", "linkText": "div" }, "ul": { "refId": "ul", "type": "htmlAam", "value": "ul", "linkText": "ul" }, "generic": { "refId": "generic", "type": "aria", "value": "generic", "linkText": "generic" } }, |
Contributor
Author
There was a problem hiding this comment.
Had to account for the deleted generic reference that was removed in this PR. Otherwise, was experiencing crashes with latest dump
stalgiag
approved these changes
Nov 6, 2025
Contributor
stalgiag
left a comment
stalgiag
left a comment
There was a problem hiding this comment.
Thanks for handling this! Test and addresses the issue. Great work!
howard-e
added a commit
that referenced
this pull request
Nov 6, 2025
…perties (#1617) * Update import-tests script to save the latest support.json on the server. Use the support.json to mutate references when needed for the reference linkText and value * Fix noisy autoformat * Update snapshots * Fix e2e selector * Fix tests * Change how support.json is imported * Remove unnecessary commented block * fix: ARIA and HTML feature reports are errantly combined and incorrectly named in the first column of the top-level report page (#1618) * Use reference.rawValue for ARIA and HTML features table column * Update links to feature pages and download urls to be reference type specific * Update snapshots * Fix tests * Fix tests * Fix tests * Fix tests * Update snapshots
howard-e
added a commit
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1610
Branched off of work in #1617