Support assertionExceptions without priority prefix #1053
Conversation
howard-e
left a comment
howard-e
left a comment
There was a problem hiding this comment.
@evmiguel looks good! Well done, in also considering a lot of these files are new to you.
How this is done also makes it so that there shouldn't be any additional changes to how the harness files or the aria-at-app handle these assertionExceptions which is great!
lib/data/parse-test-csv-row.js
Outdated
| at => at.key === key && at.settings === (command.settings || 'defaultMode') | ||
| ) | ||
| ) { | ||
| const assertionExceptions = setDefaultAssertionExceptionsFromTest( |
There was a problem hiding this comment.
setDefaultAssertionPriority seems like a more appropriate name here
howard-e
left a comment
howard-e
left a comment
There was a problem hiding this comment.
Looks good! Thanks for addressing that last bit of feedback and addressing the issue with the false error being thrown. Great stuff!
|
@mcking65 this PR should now address #1046. So making it possible that instances of valid assertionIds can be listed in Could you confirm this works as expected? |
# Conflicts: # lib/data/process-test-directory/index.js
Preview Tests
This PR addresses #1046, providing support for test plans with assertionExceptions that do not have a priority prefix.
The following changes were added: