Skip to content

Conversation

@IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Oct 4, 2024

Preview Tests

Preview disclosure nav menu test plan

Preview of all Test plans

Changelog: Adjustments to Navigation and Assertion Priorities

  1. Removed role 'list' assertion throughout the entire plan.
  2. Removed assertions related to list items throughout the entire plan.
  3. Changed the 'list boundary' assertion priority to 'May,' except when navigating with arrow keys (tests 1 to 4, 9, 10, and 12).
  4. Removed 'list boundary' assertion for commands b, f, j, Shift+Tab, Shift+b, Shift+f, and Shift+j (tests 1 to 4). This change also applies to link commands such as u, k, and l.
  5. Changed the role 'navigation landmark' and name 'Mythical University' assertion priority to 'Must' when navigating with arrow keys (tests 1 to 4).
  6. Removed role 'navigation landmark' and name 'Mythical University' assertions for commands b, f, j, Shift+b, Shift+f, Shift+j, and changed their priority to 'May' for the Tab command (tests 1 to 4).

@IsaDC IsaDC requested a review from mcking65 October 4, 2024 02:10
@mcking65
Copy link
Contributor

Per conversation in today's meeting, I deleted test 9, navFromExpandedDisclosureButtonToLinkAssociatedDropdown, and deleted commands for that test.

Here is info about some of the other changes I made that were discussed in the meeting.

Test Changes

NVDA conveys container information when navigating with quick keys. I changed conveying that information to optional for all commands so it is not classified as excess verbosity for screen readers that do it.

Test Prior Assertions New Assertions
navForwardsToCollapsedDisclosureButton 0:roleNavigationLandmark 0:nameMythicalUniversity 0:listBoundary roleButton nameAbout stateCollapsed 3:roleNavigationLandmark 3:nameMythicalUniversity 3:listBoundary roleButton nameAbout stateCollapsed
navBackToCollapsedDisclosureButton 0:roleNavigationLandmark 0:nameMythicalUniversity 0:listBoundary roleButton nameAcademics stateCollapsed 3:roleNavigationLandmark 3:nameMythicalUniversity 3:listBoundary roleButton nameAcademics stateCollapsed
navForwardsToExpandedDisclosureButton 0:roleNavigationLandmark 0:nameMythicalUniversity 0:listBoundary roleButton nameAbout stateExpanded 3:roleNavigationLandmark 3:nameMythicalUniversity 3:listBoundary roleButton nameAbout stateExpanded
navBackToExpandedDisclosureButton 0:roleNavigationLandmark 0:nameMythicalUniversity 0:listBoundary roleButton nameAcademics stateExpanded 3:roleNavigationLandmark 3:nameMythicalUniversity 3:listBoundary roleButton nameAcademics stateExpanded
navFromExpandedDisclosureButtonToLinkAssociatedDropdown 0:listBoundary roleLink nameOverview 3:listBoundary roleLink nameOverview
navFromExpandedDisclosureButtonToCurrentPageLink 0:listBoundary roleLink nameOverview stateCurrentPage 3:listBoundary roleLink nameOverview stateCurrentPage

Editorial changes not discussed in meeting

Because there are so many different elements, I made sure it is clear which element an assertion is about with the following editorial changes. In general, this is typically best practice except in some of the simplest test cases.

Original assertion Wording New Assertion Wording
convey name 'About' convey name of the button, 'About'
convey name 'Academics' convey name of the button, 'Academics'
convey name 'Admissions' convey name of the button, 'Admissions'
convey name 'Campus Tours' convey name of the link, 'Campus Tours'
convey name 'Mythical University' convey name of the navigation region, 'Mythical University'
convey name 'Mythical University sample page content' convey name of the region, 'Mythical University sample page content'
convey name 'Overview' convey name of the link, 'Overview'
State 'collapsed', is conveyed State of the button, 'collapsed', is conveyed
convey state 'collapsed' convey state of the button, 'collapsed'
convey state 'expanded' convey state of the button, 'expanded'
State 'current page' is conveyed State of the link, 'current page' is conveyed
convey state 'current page' convey state of the link, 'current page'

@IsaDC IsaDC merged commit 679784e into master Oct 10, 2024
7 checks passed
@IsaDC IsaDC deleted the tests/disclosure-navigation-v2Fix branch October 10, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants