Skip to content

Conversation

@IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Aug 18, 2025

@IsaDC IsaDC requested a review from mcking65 August 19, 2025 01:13
@mcking65
Copy link
Contributor

mcking65 commented Aug 21, 2025

@IsaDC

I found some other changes that I think are necessary. To help speed things up, I pushed commits for them. Please review them and merge if good.

changed NVDA commands for tests 11 and 12

I removed down arrow from Test 11: Navigate to the next tab in a tab list.
I remove up arrow from Test 12: Navigate to the previous tab in a tab list.
These don't work because all the tabs are on the same line.

Tablist boundary assertion for test 13

For test 13: Navigate forwards to a tab panel

The user is navigating out of the tablist to get to the tabpanel. When arrowing, that should be conveyed. When tabbing, it is optional. I added an assertion for this.

Change assertions for test 14

Test 14: Navigate backwards to a tab panel

  • It was requiring name and role and had a priority 2 assertion for tabpanel boundary.
  • JAWS and VoiceOver do not convey name, and I don't think it should be required.
  • Role is implied in the boundary assertion.
  • I changed the boundary to required, removed role, and made name optional.
  • For VoiceOver, I removed the shift+tab command

@IsaDC
Copy link
Contributor Author

IsaDC commented Aug 21, 2025

Thank you @mcking65

This is ready to go.

@IsaDC IsaDC merged commit 691168d into master Aug 21, 2025
9 checks passed
@IsaDC IsaDC deleted the tests/tabs-automatic-activation-fix branch August 21, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants