Update internal terminology to match UI #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename "unexpected behaviors" and "undesirable behaviors" to "negative
side effects".
The modifications in patch were generated with the following command:
git ls-files -z tests/resources |
xargs -0 sed -i \
-e 's/\(unexpected\|undesirable\)\([- ]\)behavior/negative\2side\2effect/g' \
-e 's/\(Unexpected\|Undesirable\) behavior/Negative side effect/g' \
-e 's/\(Unexpected\|Undesirable\) Behavior/Negative Side Effect/g' \
-e 's/\(unexpected\|undesirable\)Behavior/negativeSideEffect/g' \
-e 's/\(Unexpected\|Undesirable\)Behavior/NegativeSideEffect/g' \
-e 's/\(has\|Has\|doesNotHave\)Unexpected/\1NegativeSideEffect/g'
howard-e
reviewed
Aug 26, 2025
Contributor
howard-e
left a comment
howard-e
left a comment
There was a problem hiding this comment.
Closely related to my review comment in the app PR, what would you think of also addressing these 2 instances of "undesirable"?
Contributor
Author
|
All set! |
howard-e
approved these changes
Sep 2, 2025
Contributor
howard-e
left a comment
howard-e
left a comment
There was a problem hiding this comment.
Looks good! Also approved the related aria-at-app#1498. As noted there, feel free to merge once timing of this has been finalized.
Great stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
Rename "unexpected behaviors" and "undesirable behaviors" to "negative side effects".
The modifications in patch were generated with the following command:
This patch depends on w3c/aria-at-app#1498