Skip to content

Conversation

@howard-e
Copy link
Contributor

@howard-e howard-e commented Nov 3, 2025

Preview Tests

Branched off of work in #1334. Additional updates may be merged into this PR while work continues there.

@howard-e howard-e changed the title Examples for "Support for subfolders in /tests/*" Examples for "Support subfolders in /tests/*" Nov 3, 2025
@mcking65
Copy link
Contributor

mcking65 commented Nov 5, 2025

@howard-e

Somehow I broke the system ... there are no longer any checks and now the preview page does not exist. I pushed a commit where I renamed the directory from fake-alert to aria-required and renamed the alert.html to aria-required.html but I didn't think to change the references.csv before pushing. That caused a failure. Then, I fixed references.csv. After pushing that, the checks disappeared. I removed the lines from references.csv for the APG example and APG design pattern because they are not relevant to the test ... could that be causing a problem?

@howard-e howard-e changed the base branch from tests-sub-folder-support to master November 5, 2025 21:55
@howard-e
Copy link
Contributor Author

howard-e commented Nov 5, 2025

@howard-e

Somehow I broke the system ... there are no longer any checks and now the preview page does not exist. I pushed a commit where I renamed the directory from fake-alert to aria-required and renamed the alert.html to aria-required.html but I didn't think to change the references.csv before pushing. That caused a failure. Then, I fixed references.csv. After pushing that, the checks disappeared. I removed the lines from references.csv for the APG example and APG design pattern because they are not relevant to the test ... could that be causing a problem?

@mcking65 no error of yours! Rather, forgot Netlify requires the branch pointing to the default branch to do previews. The preview link is back now so you can check out the aria-required page here now

@howard-e
Copy link
Contributor Author

howard-e commented Nov 5, 2025

@mcking65 apologies for the above commits. Thought there was another netlify build error here still but seems like you just have to update tests/aria/aria-required/data/scripts.csv from setFocusOnButton to setRequiredFalse

@mcking65 mcking65 changed the base branch from master to tests-sub-folder-support November 6, 2025 04:36
@mcking65
Copy link
Contributor

mcking65 commented Nov 6, 2025

somehow the base was changed to master. I changed it back to tests-sub-folder-support

Base automatically changed from tests-sub-folder-support to master November 6, 2025 21:57
# Conflicts:
#	scripts/test-reviewer/generateReviewPages.mjs
@howard-e howard-e changed the title Examples for "Support subfolders in /tests/*" Examples for supporting subfolders in /tests/* Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants