-
Notifications
You must be signed in to change notification settings - Fork 138
Update: change default role for custom elements #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scottaohara
wants to merge
16
commits into
main
Choose a base branch
from
custom-element-role-change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3fd715c
Update: change default role for custom elements
scottaohara 2e4fe8f
fix typo / missing in-page link id
scottaohara 0d94242
Update html-aam/index.html
scottaohara a40c5e0
Update html-aam/index.html
scottaohara 34ceeb0
Update html-aam/index.html
scottaohara 6f6ebf8
update per feedback/discussion about referenced elements
scottaohara ae672af
Update index.html
scottaohara 2215edc
Update html-aam/index.html
scottaohara 7ef3647
Update html-aam/index.html
scottaohara 1c00754
or else if otherwise sure?
scottaohara 2532049
combining things
scottaohara 9a1e54a
add in no shadow root use cae
scottaohara 620e070
Update html-aam/index.html
scottaohara e2c538d
Update html-aam/index.html
scottaohara 499fe99
Update html-aam/index.html
scottaohara a4d84a8
Update html-aam/index.html
scottaohara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be done even if a custom element's ShadowRoot has delegatesFocus: true? It's a tricky one. On one hand, it's a pretty important principle to expose focusable elements to accessibility. On the other hand, when delegatesFocus is true, the element isn't in the tab order; it is effectively transparent as far as focus is concerned.
I think it's probably safer to still use role="group" even for delegatesFocus: true. For example, browser native date/time inputs expose the container and allow it to be focused, even though it isn't part of the tab order. Nevertheless, I thought I'd clarify because I haven't seen any discussion of delegatesFocus either here or in #2303.