-
Notifications
You must be signed in to change notification settings - Fork 756
[css-fonts-5] Define behavior for <meta text-scale> from #12380 #13052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -25,6 +25,7 @@ spec:css-color-4; type:property; text:color | |||||
| spec:css-values; type:value; text:ex | ||||||
| spec:css22; type:value; for:/; text:block | ||||||
| spec:html; type:element; text:font | ||||||
| spec:html; type:element; text:meta | ||||||
| spec:css-fonts-4; type:property; text:font-size | ||||||
| spec:css-fonts-4; type:descriptor; text:font-language-override | ||||||
| spec:css-fonts-4; type:property; text:font-family | ||||||
|
|
@@ -59,7 +60,78 @@ rules defined in CSS Fonts Level 4. | |||||
| This specification is currently a delta to the CSS Fonts Level 4 specification. | ||||||
| Do not assume that if something is not here, it has been dropped. | ||||||
|
|
||||||
| <h2 id="text-scale-meta"> | ||||||
| Text-Scale <code class=html><meta></code> element</h2> | ||||||
|
|
||||||
| A document with a <{meta}> tag | ||||||
| whose <code>name</code> attribute | ||||||
| is a <a>ASCII case-insensitive</a> match for | ||||||
| <dfn lt=text-scale><code>"text-scale"</code></dfn> | ||||||
| is recognized as setting the computed value | ||||||
| of the ''font-size/medium'' font size | ||||||
| and consequently scaling the computed size of the other <<absolute-size>> keywords. | ||||||
|
|
||||||
| The value of the <code>content</code> | ||||||
| attribute must be an <a>ASCII case-insensitive</a> match for one of the | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Must -> otherwise what?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added 'Otherwise the tag is ignored.'
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm wondering specifying the 'otherwise' case is neccessary here, because, to me, the HTML spec seems to imply it is ignored anyway. |
||||||
| recognized keywords. Otherwise the tag is ignored. | ||||||
|
|
||||||
| Documents without this <code><meta></code> tag will have an assumed default | ||||||
| value of <code>legacy</code>. | ||||||
|
|
||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be good to add an example block here, similar to the example in the HTML spec for the |
||||||
| <h3 id="text-scale-meta-keywords"> | ||||||
| Keywords</h3> | ||||||
|
|
||||||
| The recognized keywords in the [=text-scale=] | ||||||
| <{meta}> element are: | ||||||
|
|
||||||
| <dl> | ||||||
| <dt><dfn for="text-scale"><code>legacy</code></dfn></dt> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 'Legacy' is in a code element, but 'scale' isn't. Maybe this should be removed?
Suggested change
|
||||||
| <dd>''env()/preferred-text-scale'' returns the user's OS-level font factor on mobile, | ||||||
| but 1 on desktop. | ||||||
| The document's initial font size only incorporates UA-level font preferences. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's still a few other places that say 'initial font size'. These will also need to be updated to |
||||||
| OS-level font preferences are ignored.</dd> | ||||||
| <dt><dfn>scale</dfn></dt> | ||||||
| <dd>''env()/preferred-text-scale'' returns the user's OS-level font preferences. | ||||||
| The document's initial font size incorporates both UA-level and OS-level font preferences.</dd> | ||||||
| </dl> | ||||||
|
|
||||||
| <h3 id="legacy-keyword">The 'legacy' keyword</h3> | ||||||
|
|
||||||
| When the value of the [=text-scale=] content attribute is | ||||||
| [=text-scale/legacy=] | ||||||
| the user agent must set the computed ''font-size/medium'' font size | ||||||
| to 16px multiplied by | ||||||
| the font scale factor | ||||||
| the user has chosen from any settings <i>provided by the user agent</i>. | ||||||
| The ''preferred-text-scale'' value must be 1 on desktop platforms. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wherever you reference the |
||||||
| On mobile: | ||||||
| <ul> | ||||||
| <li>if the operating system provides a text scale setting AND the UA hasn't already applied that factor to the initial font size, ''env()/preferred-text-scale'' returns the mulitplier that the user has chosen in the operating system's text scale setting. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo
Suggested change
|
||||||
|
|
||||||
| Note: As of this writing, all combinations of Android, iOS, Gecko, WebKit, Blink satisfy this first condition. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe 'At the time of publishing'? |
||||||
|
|
||||||
| </li> | ||||||
| <li>Otherwise ''env()/preferred-text-scale'' returns 1.</li> | ||||||
| </ul> | ||||||
|
|
||||||
| <h3 id="scale-keyword">The 'scale' keyword</h3> | ||||||
|
|
||||||
| The <dfn for="text-scale" export><code>scale</code></dfn> property is | ||||||
| recognized in the [=text-scale=] content attribute value. | ||||||
|
|
||||||
| When the value of the [=text-scale=] content attribute is | ||||||
| <a for=text-scale>scale</a> | ||||||
| computed ''font-size/medium'' font size must match the user's preferred paragraph text size as determined from a combination of OS and UA preferences. | ||||||
|
|
||||||
| The ''env()/preferred-text-scale'' value must be a number that, | ||||||
| when multiplied by 16px, | ||||||
| provides a <<length>> that matches that of the initial font size. | ||||||
|
|
||||||
| Further, when the value of the [=text-scale=] content attribute is | ||||||
| <a for=text-scale>scale</a>, the user agent should skip all font-sizing interventions it would otherwise perform in an attempt to automatically honor the user's preferences. E.g. text autosizing on mobile (See [[css-size-adjust#intro]]) and full-application zoom (<a href="https://github.com/w3c/csswg-drafts/blob/main/css-env-1/explainers/env-preferred-text-scale.md#windows-11">popular browsers do this on Windows)</a>. | ||||||
|
|
||||||
| Note: It is expected that authors will use | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using active voice for the first sentence. So:
|
||||||
| ''<meta name="text-scale" content="scale">'' in stylesheets so that the initial font size will reflect a combination of the user's font preferences, whether those are specified at the OS level or the UA level. The author will then be able to use ''rem'' throughout the page to honor the user's font preferences. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe the sentence about using So you could keep the Note block to explain how authors are expected to use Also, I'm not sure if the Note should actually be an orange Assertion box. But maybe not because assertions are normative? Where I've seen Assertion boxes in the past are places like the css-flexbox spec, where it tells authors to use the |
||||||
|
|
||||||
| <h3 id="values"> | ||||||
| Value Definitions</h3> | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the HTML spec also mentions when a metadata name should not appear more than once in the document. Maybe you should add this line somewhere: