-
Notifications
You must be signed in to change notification settings - Fork 20
Make https binding mandatory #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ottomorac
wants to merge
16
commits into
w3c:gh-pages
Choose a base branch
from
ottomorac:ottomora-https-binding
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
13a3679
Make https binding mandatory
ottomorac 5d65ed3
correct wording to did methods
ottomorac 4ed0039
Merge branch 'w3c:gh-pages' into ottomora-https-binding
ottomorac 9f2c955
specify local vs. remote resolvers
ottomorac 027e402
Update index.html
ottomorac 8ec3f33
Update index.html
ottomorac e57a848
Merge branch 'w3c:gh-pages' into ottomora-https-binding
ottomorac 55b3616
Add local and remote resolver classes
ottomorac b5ced4e
Update index.html
ottomorac c2968c0
Merge branch 'w3c:gh-pages' into ottomora-https-binding
ottomorac 4fcabb7
Add https did resolver
ottomorac 98520be
Add https did resolver
ottomorac 049536e
Simplify change to make https binding mandatory
ottomorac e81362a
Simplify change to make https binding mandatory
ottomorac 1933fd4
Simplify change to make https binding mandatory
ottomorac 9d25698
Update index.html
ottomorac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand this sentence.. If I implement a
did:keyresolver that only works as a library and doesn't include an HTTPS binding, does that mean it's not conformant?Maybe this is supposed to say "All conformant DID methods" instead of "All conformant DID resolvers"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Markus. I changed it to say "All conformant DID methods".
I was unsure also about the second part, in this comment #93 (comment) Manu and Joe had indicated that there could be 2 classes of conformance "separate out libraries from resolver deployments that include HTTPS" but I am not sure how to word 2 classes of conformance in the spec. Apologies, this is new ground for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this link that Will mentioned to me around what are conformance classes so we can discuss during the wg call: https://w3c.github.io/did-resolution/#conformance