-
Notifications
You must be signed in to change notification settings - Fork 20
Standardize error responses per id (#212) #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
|
@erdemonal11 I know I agreed with your idea in my comment #212 (comment), but now after reviewing the PR, I am wondering if this change is really the right thing to do. My interpretation of the current spec text is that in case of an error, a resolver would still return a full But maybe we should discuss this in the WG. In other words, I think the question is whether the error response content should look like this: {
"didDocument": null,
"didResolutionMetadata": {
"error": {
"type": "NOT_FOUND",
"title": "The DID or DID document was not found.",
"detail": "No resolve result for did:method:BDrEcHc8Tb4Lb2VyQZWEDE"
}
},
"didDocumentMetadata": {}
}Or like this: {
"type": "NOT_FOUND",
"title": "The DID or DID document was not found.",
"detail": "No resolve result for did:method:BDrEcHc8Tb4Lb2VyQZWEDE"
} |
|
@erdemonal11 We discussed this in the DID WG meeting yesterday: In this meeting, we thought that it's better to leave things as-is. In other words, in case of an error, we include the Would this be fine with you, or do you see any problems with this? |
|
@peacekeeper It is fine for me I checked and I don't see any problems. |
Thank you, in this case should we close this PR here? Alternatively you could update the PR so the 4xx and 5xx responses reference |
|
@peacekeeper The error responses now reference |
Fixes #212
This pull request updates the OpenAPI specification to provide a consistent error response structure, as discussed in the issue.
It adds a
contentblock referencingRFC9457ProblemDetailsto all4xxand5xxerror responses.