For best case size computation add a configurable reduction percentage. #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merger prunes patch pairs from evaluation by looking at a "best case" cost reduction. During this calculation the size of the merged patch is estimated using the size of the individual patches being merged. The following forumula is used: merged_size = largest_individual_patch_size + best_case_size_reduction_fraction * sum of remaining patch sizes Setting best_case_size_reduction_fraction to 0 gives the previous behaviour, larger values cause more aggressive pruning, at the cost of possibly underestimating the true best case for a pair, and over pruning pairs that may have actually been viable. Also adds a flag that when enabled has the merger record a histogram of encountered size reductions. This was used on a few example fonts to inform the default value of 0.50. In testing the default value gives a significant speedup, while having neglible impact on the total cost of produced segmentations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merger prunes patch pairs from evaluation by looking at a "best case" cost reduction. During this calculation the size of the merged patch is estimated using the size of the individual patches being merged. The following forumula is used:
Setting best_case_size_reduction_fraction to 0 gives the previous behaviour, larger values cause more aggressive pruning, at the cost of possibly underestimating the true best case for a pair, and over pruning pairs that may have actually been viable.
Also adds a flag that when enabled has the merger record a histogram of encountered size reductions. This was used on a few example fonts to inform the default value of 0.50. In testing the default value gives a significant speedup, while having neglible impact on the total cost of produced segmentations.