Removing unnecessary spans from example #7 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Jan 16, 2018
Member
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
Approving, but noting that there is now a better example in the actual spec.
Author
|
Thanks for the heads up. I'll change it to match the better example. |
Author
|
@marcoscaceres got a link? I looked through the spec but couldn't find the better example. There are some slightly different one but couldn't quick pick one, Ha. Let me know which example you were thinking of and I'll update this to reflect that. |
Member
|
@ericduran, see example 1 here: https://w3c.github.io/user-timing/#introduction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the example code was copied from a render output (post code highlight). So it had all the extra spans in the source.
This cleans up the source code but it also has the added benefit of also fixing the highlight (which wasn't working before because of the spans).
Note: I kept the styling the same as it was before but it's not really consistent with other examples in the perf specs, let me know. I can clean that up.
Before:
After: