-
Notifications
You must be signed in to change notification settings - Fork 330
Add notes to 2.4.3 understanding to try and address static content receiving focus and what does/doesn't constitute a focus order failure #1643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
417b9ff
Add notes to 2.4.3 understanding
patrickhlauke 3d08ead
Tweak note about redundant focus stops
patrickhlauke d0138bd
Expand note to mention "card" component, give code example for nested…
patrickhlauke 7cd188a
Remove the "redundant" part
patrickhlauke 8be23bd
Remove "normatively"
patrickhlauke 29dcb88
Tweak language based on suggestions from @alastc @mbgower @bruce-usab
patrickhlauke c3e0403
Fix spacing/indentation
patrickhlauke 147b6fe
Tweak/expand the "western left-to-right" part
patrickhlauke 0028075
Update focus-order.html
mbgower 8667b31
Update focus-order.html
mbgower d0382d3
Update understanding/20/focus-order.html
patrickhlauke 9f7feb7
Remove unnecessary "unnecessarily"
patrickhlauke 083dbab
Update understanding/20/focus-order.html
alastc d841c2a
Tweaks/rewordings
patrickhlauke 61fda92
Capitalisation
patrickhlauke 116e230
"too many" > "unwarranted"
patrickhlauke aa6dcd8
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke 3e33e78
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke 14dc43e
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke df6eed7
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke 42da714
Update understanding/20/focus-order.html
patrickhlauke ad8f4fb
Update understanding/20/focus-order.html
patrickhlauke dc8904c
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke 18d56fe
Update understanding/20/focus-order.html
patrickhlauke 509dad6
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke b3cecfb
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke 7fd76fa
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke 526ced4
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
patrickhlauke d077606
Update understanding/20/focus-order.html
mbgower 8170927
Update understanding/20/focus-order.html
mbgower f2c00e2
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
mbgower 1defc51
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
mbgower dcbbb0c
Add missing language-html class to new code block
kfranqueiro cdd58fe
Merge branch 'main' into patrickhlauke-understanding-focus-order-note
mbgower File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that I agree with this statement. The issue is that the interpretation of the visual presentation is subjective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not necessarily need to follow visual presentation, perhaps? i've seen extreme cases where auditors gleefully fail things if they're not exactly in the same order as the visual, with things like three little icon-based buttons that receive focus right-to-left instead of left-to-right (because the author used CSS floats that effectively reversed the order) ... but where the meaning was not impacted and it was not really a problem.
there must be some way we can somehow make that clear...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, add "necessarily".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if it's too handwavy though. maybe best to expand this, or add some more words that reflect what @awkawk rightly says...that it's subjective?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is deciding what is the visual presentation order? Shouldn't the tab order follow whatever that is decided to be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or adding "as long as meaning/operation are not affected"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Who is deciding what is the visual presentation order?" not sure i follow...is this rhetorical? the author/designer will work on the visual/layout, but for various reasons the focus order may be slightly different. the point is that as long as meaning/operation aren't affected (and it's...subjectively...not too haphazard jumping all over the place) it's not necessarily a failure if the focus order doesn't strictly follow the western top-to-bottom/left-to-right (in left-to-right writing cultures)