Skip to content

Update ARIA11 to address issue #1308 #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Update ARIA11 to address issue #1308 #2339

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a8ae1a
Update ARIA11 to address issue #1308
fstrr Apr 29, 2022
3168a49
Merge branch 'main' into fstrr-patch-4
fstrr May 28, 2024
b3b0396
Add in accessible name requirement for form
fstrr May 28, 2024
ee5123f
Updated landmarks content based on feedback
fstrr Nov 15, 2024
5a2bacb
Merge branch 'main' into fstrr-patch-4
mbgower Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion techniques/aria/ARIA11.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ <h1>Using ARIA landmarks to identify regions of a page</h1>
<li><code class="language-html">navigation</code>: A region that contains navigation links links to other pages or different parts of the same page.</li>
<li><code class="language-html">main</code>: A region that contains a page's main content.</li>
<li><code class="language-html">region</code>: A region that contains a perceivable section of the page containing content that is sufficiently important for users to be able to navigate to the section. A <code class="language-html">region</code> landmark isn't exposed as a landmark region unless it has an accessible name.</li>
<li><code class="language-html">form</code>: A region of the document that represents a collection of form-associated elements, some of which can represent editable values that can be submitted to a server for processing.</li>
<li><code class="language-html">form</code>: A region of the document that represents a collection of form-associated elements, some of which can represent editable values that can be submitted to a server for processing. It maps to <code class="language-html">form</code> in HTML, and needs an accessible name to be exposed as a landmark.</li>
Copy link
Member

@scottaohara scottaohara Jun 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not against the idea of mentioning what element this maps to in html - but now this is the only one that does.

if adding those references to the other landmarks, that's a bit out of scope.... and if this PR goes out of scope, there are a bunch of other nits i have with this doc.

should we make all those updates now, or just address the issue specifically - and then make those other changes (including referencing the HTML elements the landmarks can be exposed from) in another PR?

Copy link
Contributor Author

@fstrr fstrr Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends! I'm increasingly not a fan of PRs that wander off topic, but if it's just a couple of minor things then we could add them. I could also back out the mapping content to put in another PR if your bunch of nits is large.

<li><code class="language-html">search</code>: A region of the page containing search functionality.</li>
<li><code class="language-html">complementary</code>: Any section of the document that supports the main content, yet is separate and meaningful on its own.</li>
<li><code class="language-html">contentinfo</code>: A region that contains information about the parent document such as copyrights and links to privacy statements.</li>
Expand Down