-
Notifications
You must be signed in to change notification settings - Fork 327
Improve the SC 2.1.2 No Keyboard Trap Understanding #4316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Moving dialog example higher because it is more common
| <p>The keyboard focus is not considered as trapped when the user can navigate away from a UI | ||
| component using the unmodified tab or arrow keys or when another “standard exit method” exists. | ||
| What is a “standard exist method” depends on the user’s hardware and software. A press | ||
| of the <kbd>ESC</kbd> key is such a “standard exit method”. When the press of the hardware back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "When" sentence doesn't quite work structure-wise
|
|
||
|
|
||
| <p>The intent of this success criterion is to ensure that that content does not “trap” the | ||
| keyboard focus within subsections of content on a web page or app. It is common to restrict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "It is common..." insert here seems out of place. I'd move it to the next paragraph, and change this back to talking about the problem
|
x-ref #4381 |
Co-authored-by: Patrick H. Lauke <[email protected]>
|
Thanks for the review and feedback, @patrickhlauke! |
|
patrickhlauke marked as non substantive for IPR from ash-nazg. |
Ports over most of the ideas from #4316, but extends/clarifies them further.
|
Closing this draft PR in favour of #4726 (as this PR here has conflicts, and it won't allow changes to be pushed to it) |
Very drafty Friday afternoon start of an improvement here.