-
Notifications
You must be signed in to change notification settings - Fork 327
Total rewrite of example for SCR27 #4558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Total rewrite of example for SCR27 #4558
Conversation
Merge modified test branch into my fork's main
ACT rules update from https://github.com/w3c/wcag-act-rules/commit/2a…
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
If you could do that, that would be great—it'll be much easier to review it. Thanks :) |
Also contains working example html files
|
Hi |
|
patrickhlauke marked as non substantive for IPR from ash-nazg. |
|
@joshuamaker8-create generally, only a handful of people can actually merge here (as we go through a whole process first). separately though, your user is not in the IPR contribution list (people who confirmed that they won't make an IP claim later on on their work). that, i can fix for you (marking your contribution as not significant for IPR) |
|
@patrickhlauke Thanks for helping! I am quite inexperienced with Github, don't quite know how it all works yet. Merging is blocked, so what should I do for the next step? |
|
nothing. we'll now review this and, if deemed appropriate, we'll merge it |
|
Okay. Thanks :) |
The example for SCR27 was broken. The code was out of date and unsupported by all browsers. According to Blame 2 years ago the example needed to be completely redone.
I did an example from scratch.
My example itself conforms to WCAG 2.2, in terms of contrast, visibility, etc.
My example is detail heavy, both in CSS and JS. This was necessary to make the example fully functional, not just a skeleton framework.