Skip to content

Conversation

@joshuamaker8-create
Copy link

The example for SCR27 was broken. The code was out of date and unsupported by all browsers. According to Blame 2 years ago the example needed to be completely redone.

I did an example from scratch.

My example itself conforms to WCAG 2.2, in terms of contrast, visibility, etc.

My example is detail heavy, both in CSS and JS. This was necessary to make the example fully functional, not just a skeleton framework.

@netlify
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 39fc6fb
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/68fc8d85ae7223000827b19d
😎 Deploy Preview https://deploy-preview-4558--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joshuamaker8-create
Copy link
Author

My example is detail heavy, both in CSS and JS. This was necessary to make the example fully functional, not just a skeleton framework.
I have read the contributor guidelines now and will rewrite this example to conform to editing guidelines, making it simple and not intensive like it is currently. This current example that I have created will be turned into a working example, as that seems more appropriate now.

@fstrr
Copy link
Contributor

fstrr commented Aug 18, 2025

This current example that I have created will be turned into a working example, as that seems more appropriate now.

If you could do that, that would be great—it'll be much easier to review it. Thanks :)

@joshuamaker8-create joshuamaker8-create marked this pull request as ready for review August 21, 2025 11:43
@joshuamaker8-create
Copy link
Author

Hi
I don't know how to get this pull request to merge, there is a failing check
"PR has contribution issues. The following users were not in the repository's groups: @joshuamaker8-create "
Can I transfer this to someone else that can merge it?

@w3cbot
Copy link

w3cbot commented Oct 25, 2025

patrickhlauke marked as non substantive for IPR from ash-nazg.

@patrickhlauke
Copy link
Member

@joshuamaker8-create generally, only a handful of people can actually merge here (as we go through a whole process first). separately though, your user is not in the IPR contribution list (people who confirmed that they won't make an IP claim later on on their work). that, i can fix for you (marking your contribution as not significant for IPR)

@joshuamaker8-create
Copy link
Author

@patrickhlauke Thanks for helping! I am quite inexperienced with Github, don't quite know how it all works yet. Merging is blocked, so what should I do for the next step?

@patrickhlauke
Copy link
Member

nothing. we'll now review this and, if deemed appropriate, we'll merge it

@joshuamaker8-create
Copy link
Author

Okay. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants