Skip to content

Conversation

@nickmoreton
Copy link
Collaborator

@nickmoreton nickmoreton commented May 11, 2025

This pull request introduces updates to the wagtail-wordpress-import package, focusing on improving documentation, refining the logging mechanism, and enhancing test coverage. Key changes include updates to the README.md for clarity, adjustments to the logging setup in the import command, and modifications to test cases to align with the new logging structure.

Documentation Updates:

  • Updated README.md to improve clarity and provide more detailed instructions for setup, usage, and logging behavior, including guidance on handling the log folder and CSV files generated during the import process. [1] [2] [3] [4] [5]

Logging Enhancements:

  • Refactored the logging setup in import_xml.py to dynamically create and clean the log directory at runtime, ensuring a fresh state for each import process. [1] [2]

Test Updates:

  • Updated test cases to align with the new logging structure by removing hardcoded log directory paths and ensuring compatibility with the dynamic log directory creation. [1] [2] [3] [4] [5] [6] [7] [8]

Ticket URL:


Testing

  • CI passes
  • If necessary, tests are added for new or fixed behaviour
  • These changes do not reduce test coverage

Documentation.

  • This PR adds or updates documentation
  • Documentation changes are not necessary because:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link URL hosts aren't updated on import Small typo in README

2 participants