feat: incorporate sds-r into reliable channels #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
jm-clius
force-pushed
the
feat/sds-r-in-reliable-channels
branch
2 times, most recently
from
90fddd2 to
3ba50d4
Compare
jm-clius
force-pushed
the
feat/sds-r-in-reliable-channels
branch
from
3ba50d4 to
9d82564
Compare
fryorcraken
approved these changes
Nov 18, 2025
| const log = new Logger("sdk:reliable-channel"); | ||
|
|
||
| const DEFAULT_SYNC_MIN_INTERVAL_MS = 30 * 1000; // 30 seconds | ||
| const DEFAULT_SYNC_MIN_INTERVAL_WITH_REPAIRS_MS = 10 * 1000; // 10 seconds when repairs pending |
Collaborator
There was a problem hiding this comment.
I am starting the review so it may not hold, but I wonder if instead we should use the "multiplier" concept for this, instead of different values.
| options?.processTaskMinElapseMs ?? DEFAULT_PROCESS_TASK_MIN_ELAPSE_MS; | ||
|
|
||
| if (this._retrieve) { | ||
| this.retrievalStrategy = options?.retrievalStrategy ?? "both"; |
Collaborator
There was a problem hiding this comment.
You are applying default twice, which is not idea. Make the retrievalStrategy a mandatory argument here, so it can be defaulted only once in create function.
Comment on lines
+514
to
+517
| // Only start repair sweep if SDS-R is enabled | ||
| if (this.shouldUseSdsR()) { | ||
| this.startRepairSweepLoop(); | ||
| } |
Collaborator
There was a problem hiding this comment.
I wonder if it's better to put the check inside startRepairSweepLoop to be simpler and safer.
| } | ||
|
|
||
| private stopRepairSweepLoop(): void { | ||
| if (this.sweepRepairInterval) clearInterval(this.sweepRepairInterval); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (this.sweepRepairInterval) clearInterval(this.sweepRepairInterval); | |
| if (this.sweepRepairInterval) { | |
| clearInterval(this.sweepRepairInterval); | |
| this.sweepInBufInterval = undefined; | |
| } |
It's apparently better.
Comment on lines
+596
to
+598
| const baseInterval = hasPendingRepairs | ||
| ? DEFAULT_SYNC_MIN_INTERVAL_WITH_REPAIRS_MS | ||
| : this.syncMinIntervalMs; |
Collaborator
There was a problem hiding this comment.
WDYT about doing a multiplier of 0.3 or 0.5 instead?
Comment on lines
+753
to
+759
| // Store retrieval (for 'both' and 'store-only' strategies) | ||
| // SDS-R repair happens automatically via RepairManager for 'both' and 'sds-r-only' | ||
| if ( | ||
| this.shouldUseStore() && | ||
| retrievalHint && | ||
| this.missingMessageRetriever | ||
| ) { |
Collaborator
There was a problem hiding this comment.
unnecessary, as missingMessageRetriever should not be instantiated if this.shouldUseStore is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SDS-R into reliable channels as optional parallel or singular strategy for recovery.
There are three main design choices that need review here:
SDS-R by default functions as a parallel mechanism to store retrieval: there is no lockstep mechanism where the one retrieval strategy serves as fallback if the other fails. This seems to me the most natural way of integrating SDS-R, after some consideration. In general, a reliable channels instance will attempt store retrieval after detecting a missed dependency without delay. SDS-R will kick in with some delay (generally min 30s). If by that point the missing dependency has been received (via relay or via Store retrieval), the pending repair will be removed from the buffer and never enter an SDS-R exchange. There is however a possible race condition that can cause a missing dependency to be requested (and retrieved) from a Store node and via SDS-R. This is not optimal, but I think a reasonable tradeoff for simplicity.
Store retrieval can now be disabled completely, adding some configuration complexity i.t.o.
retrievalStrategy("store only", "sds-r only", "both", "none"). I'm not quite convinced this level of configurability is necessary, but there seems to be some use cases for a store-less reliable channel based on recent Discord discussions.SDS-R works better if the sync period is shorter, so I've added a simple adaptive strategy that triggers Sync more often if there are pending repair requests. This has an impact on bandwidth and message rates.