Skip to content

Conversation

@tarfa
Copy link

@tarfa tarfa commented Mar 29, 2019

Changing qrCodeDisplaySize to size 41 or greater fixes this issue. I chose 43 after some trial and error as that gives a proportional border around the rendered QR code similar to what existed before.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1346

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2842 unchanged lines in 45 files lost coverage.
  • Overall coverage remained the same at 34.419%

Files with Coverage Reduction New Missed Lines %
aws/spec/cmds_defs.go 4 0.0%
template/internal/ast/build.go 7 95.07%
aws/spec/accesskey.go 8 51.67%
cloud/lazy.go 8 0.0%
cloud/cloud.go 10 0.0%
aws/spec/securitygroup.go 11 65.23%
aws/doc/paramsdoc.go 13 0.0%
template/env.go 14 72.82%
template/params/validation.go 17 54.02%
aws/spec/spec.go 18 53.08%
Totals Coverage Status
Change from base Build 1345: 0.0%
Covered Lines: 13184
Relevant Lines: 38304

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 29, 2019

Pull Request Test Coverage Report for Build 1346

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 34.419%

Files with Coverage Reduction New Missed Lines %
console/displayer.go 2 82.52%
aws/fetch/manual_fetchers.go 8 74.13%
Totals Coverage Status
Change from base Build 1345: 0.0%
Covered Lines: 13184
Relevant Lines: 38304

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants