lws/openssl-wrapper: Align ssl_handshake and openssl standard return values #3441
+238
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-developed-by: Gemini 2.5 Pro
…values standard return code of ssl_handshake list following: 0 The TLS/SSL handshake was not successful but was shut down controlled and by the specifications of the TLS/SSL protocol. Call SSL_get_error() with the return value ret to find out the reason. 1 The TLS/SSL handshake was successfully completed, a TLS/SSL connection has been established. <0 The TLS/SSL handshake was not successful because a fatal error occurred either at the protocol level or a connection failure occurred. The shutdown was not clean. It can also occur of action is need to continue the operation for non-blocking BIOs. Call SSL_get_error() with the return value ret to find out the reason. so ssl_error_read/write should return -1. Signed-off-by: makejian <[email protected]>
Member
|
I notice that we change the return code meaning, but we don't adapt the caller. Since mbedtls works today, are we sure that is a good idea? |
lws-team
force-pushed
the
main
branch
7 times, most recently
from
37dca44 to
b4c7439
Compare
lws-team
force-pushed
the
main
branch
6 times, most recently
from
c5ef352 to
46b045e
Compare
lws-team
force-pushed
the
main
branch
8 times, most recently
from
1faedc3 to
efb9f35
Compare
lws-team
force-pushed
the
main
branch
3 times, most recently
from
a0c73c1 to
7c9d4bc
Compare
lws-team
force-pushed
the
main
branch
2 times, most recently
from
217e720 to
4f15c21
Compare
lws-team
force-pushed
the
main
branch
10 times, most recently
from
a800d4a to
7f2f518
Compare
lws-team
force-pushed
the
main
branch
3 times, most recently
from
baf4897 to
0c7fa23
Compare
lws-team
force-pushed
the
main
branch
3 times, most recently
from
2b74af4 to
5f77374
Compare
lws-team
force-pushed
the
main
branch
5 times, most recently
from
a677221 to
0c67054
Compare
lws-team
force-pushed
the
main
branch
2 times, most recently
from
f5fa440 to
278c671
Compare
lws-team
force-pushed
the
main
branch
2 times, most recently
from
580b993 to
c837e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.openssl.org/1.0.2/man3/SSL_do_handshake/#return-values
standard return code of ssl_handshake list following:
0:
The TLS/SSL handshake was not successful but was shut down controlled and by the specifications of the TLS/SSL protocol. Call SSL_get_error() with the return value ret to find out the reason.
1:
The TLS/SSL handshake was successfully completed, a TLS/SSL connection has been established.
<0:
The TLS/SSL handshake was not successful because a fatal error occurred either at the protocol level or a connection failure occurred. The shutdown was not clean. It can also occur of action is need to continue the operation for non-blocking BIOs. Call SSL_get_error() with the return value ret to find out the reason.
so ssl_error_read/write should return -1.
Also mapping ssl->err from mbedtls error to openssl error, not return mbedtls error directly.