Create new queued prompts list UI#11439
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
harryalbert
changed the title
harryalbert
force-pushed
the
harry/app-4532-update-queued-prompts-to-use-new-ui
branch
from
5428969 to
332c4c9
Compare
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds a terminal-owned queued prompt model and a new queued-prompts panel, then routes /queue and auto-queue submissions through it while leaving Cloud Mode and compact placeholders on the legacy pending-user-query UI.
Concerns
- Two active-AI-block lookup paths no longer skip legacy pending-user-query rich content, so Cloud Mode/compact placeholders can hide the real active AI block from downstream logic.
- The new test modules call
QueuedQuery::into_text(), but the PR only definestext(), so the test build will fail.
Verdict
Found: 0 critical, 4 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
force-pushed
the
harry/app-4532-update-queued-prompts-to-use-new-ui
branch
from
332c4c9 to
f31a7b6
Compare
| 32. While that newly-fired prompt is mid-exchange, the rest of the queue stays intact, the panel updates the count to `<N-1> queued`, and additional prompts can still be queued at the tail. | ||
| 33. The cycle continues until either the queue is empty or one of the abort conditions in (34) fires. | ||
| ### Cancellation and error handling | ||
| 34. When the active conversation finishes for any non-`Complete` reason — `Error`, `Cancelled`, `CancelledDuringRequestedCommandExecution` — auto-fire pauses immediately. The queue is not flushed. |
There was a problem hiding this comment.
we should see how this feels in dev but I'm pretty sure that claude code auto-sends the next queued propmt on cancel
There was a problem hiding this comment.
hmm, that's interesting. I kind of think we should follow claude semantics given it's what people will expect, so I might just change this to send on cancel
harryalbert
force-pushed
the
harry/app-4532-update-queued-prompts-to-use-new-ui
branch
4 times, most recently
from
4a0343f to
e17fec3
Compare
harryalbert
force-pushed
the
harry/app-4532-update-queued-prompts-to-use-new-ui
branch
3 times, most recently
from
c2404c2 to
7afeb71
Compare
harryalbert
force-pushed
the
harry/app-4532-update-queued-prompts-to-use-new-ui
branch
from
7afeb71 to
8076558
Compare
harryalbert
deleted the
harry/app-4532-update-queued-prompts-to-use-new-ui
branch
2 participants
Description
This PR adds a new queued prompt panel, which allows for multiple queued prompts at a time, queued prompt editing, queued prompt re-arranging, and allows you to collapse your queued prompts when you don't want to look at them.
In this PR, I only update it so that direct prompt queueing uses this new UI, keeping cloud conversation setup using the old queued prompt UI. I think cloud conversation setup should use the new UI, but that's a separate workstream (that should maybe be feature flagged), so I think it deserves its own PR.
As is, the new UI is not feature flagged, as queued prompts as a whole are still in dogfood.
This is a pretty large PR, but I go into solid detail about the architecture and product decisions in the tech and product specs.
Implements APP-4563
Testing
./script/runScreenshots / Videos
https://www.loom.com/share/2689f5f8e12d4acabd14e6c3fa70c73e
Agent Mode