Skip to content

Detect common skill updates during script/run #11455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachlloyd merged 2 commits into from
May 22, 2026
Merged

Detect common skill updates during script/run #11455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
224405f
Detect common skill updates during script run
zachlloyd May 20, 2026
d94712a
Merge branch 'master' into zach/skills-installer-fixes
zachlloyd May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions script/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,6 @@ while (( "$#" )); do
esac
done

common_skills_match_lock() {
./script/resolve_common_skills install_common_skills -- --repo-root "${REPO_ROOT}" "$@" --verify-only --quiet >/dev/null 2>&1
}
install_common_skills_or_continue() {
if ! ./script/resolve_common_skills install_common_skills -- --repo-root "${REPO_ROOT}" "$@"; then
echo "error: unable to install common skills; continuing without them." >&2
Expand All @@ -116,8 +113,6 @@ if [[ "$INSTALL_COMMON_SKILLS" -eq 1 ]]; then
else
install_common_skills_or_continue --force --prompt-for-target
fi
elif common_skills_match_lock "${COMMON_SKILLS_ARGS[@]}"; then
:
else
if [[ "${#COMMON_SKILLS_ARGS[@]}" -gt 0 ]]; then
install_common_skills_or_continue "${COMMON_SKILLS_ARGS[@]}" --if-needed --quiet
Expand Down
20 changes: 19 additions & 1 deletion skills-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,18 @@
"skillPath": ".agents/skills/brandalf/SKILL.md",
"computedHash": "44eccce975aeb4df325f0112602d4e3181c80cf7febe659367c524a18dd61da9"
},
"check-impl-against-spec": {
"source": "warpdotdev/common-skills",
"sourceType": "github",
"skillPath": ".agents/skills/check-impl-against-spec/SKILL.md",
"computedHash": "c624f1667b3161022647ce8a55cb12ea781f9c85bfa0ea2dc3e17f7b1056d294"
},
"council": {
"source": "warpdotdev/common-skills",
"sourceType": "github",
"skillPath": ".agents/skills/council/SKILL.md",
"computedHash": "0eecde0e3b4e20cab0f8376c7994e7aa7b8dd2cdc6e5bb56f945baf98bef1c95"
},
"create-pr": {
"source": "warpdotdev/common-skills",
"sourceType": "github",
Expand Down Expand Up @@ -37,6 +49,12 @@
"skillPath": ".agents/skills/pr-walkthrough/SKILL.md",
"computedHash": "990e8549611cff4b82036d4c7cc50d23eb2cbb27272926142d3fd8ad17a5e18f"
},
"reproduce-bug-report": {
"source": "warpdotdev/common-skills",
"sourceType": "github",
"skillPath": ".agents/skills/reproduce-bug-report/SKILL.md",
"computedHash": "a906c867389e3ee76d9196cad893fb3ba7e5f0e27248373b53e30358aac5fe44"
},
"resolve-merge-conflicts": {
"source": "warpdotdev/common-skills",
"sourceType": "github",
Expand All @@ -47,7 +65,7 @@
"source": "warpdotdev/common-skills",
"sourceType": "github",
"skillPath": ".agents/skills/review-pr/SKILL.md",
"computedHash": "5bb3ee6ea66cd018fe6bc08d003493fc2abce29441af73e86fd35a590312eaff"
"computedHash": "f27bfc9743fa0d240763a26519b25112a0ad8652c9a2b2b52daeb7af2d2a862c"
},
"spec-driven-implementation": {
"source": "warpdotdev/common-skills",
Expand Down
Loading