Move local and remote project skills to use RepoMetadataModel#11559
Move local and remote project skills to use RepoMetadataModel#11559moirahuang wants to merge 5 commits into
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR moves project skill discovery from provider directories to concrete SKILL.md files returned by RepoMetadataModel, adding remote-path-aware discovery helpers while keeping local hydration in the watcher.
Concerns
- Queued project directory handling now treats unrelated directory creations under a skill's owning repo/subtree as relevant to existing skills, which can re-emit already loaded skills whenever ordinary directories are created.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR moves project skill discovery from the local project watcher/subscriber path onto RepoMetadataModel, adds file-based skill discovery helpers, and teaches repo metadata to eagerly load ignored skill provider paths.
Concerns
- Remote project skill paths are discovered as
LocalOrRemotePath::Remotebut then filtered throughto_local_path()before parsing, so remote repository updates still emit no project skills. - Removing the separate local project watcher also removes the code path that handled symlinked project skill directories, while repo metadata continues to skip directory symlinks.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
moirahuang
force-pushed
the
moira/skills-acquisition-repometadata
branch
from
a484e3f to
077d252
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR moves project skill discovery onto RepoMetadataModel, adds ignored-path interests so gitignored skill provider paths can be represented in repo metadata, and updates skill watcher/utils tests for local, ignored, remote-path, and symlinked project skill cases.
Concerns
- No blocking correctness or security concerns found in the annotated diff.
- Spec context: no approved or repository spec context was available for this PR.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Description
Migrates local project skills away from using
ProjectSkillSubscriberand instead setting up local and remote project skills to use the sameRepoMetadataModelpathTesting
Locally tested to make sure that local project skills still work for both regular skills and git ignored skills
./script/runScreenshots / Videos
Regular skills
https://github.com/user-attachments/assets/ce2f6abf-ecf6-4f77-8848-313b41b0a3d7
Git ignored skills
https://github.com/user-attachments/assets/27d41709-1a73-4ec7-8a69-a180ed55fa9f
Agent Mode