Stabilize vertical-tab drag visuals: overlay drop marker + post-drop hover reset#2964
Draft
Stabilize vertical-tab drag visuals: overlay drop marker + post-drop hover reset#2964
Conversation
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Deploying waveterm with
|
| Latest commit: |
48919f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd31d368.waveterm.pages.dev |
| Branch Preview URL: | https://copilot-create-vertical-tab.waveterm.pages.dev |
Copilot
AI
changed the title
[WIP] Add vertical tab bar component for Wave
Add standalone Tailwind vertical tab bar + preview (new Mar 2, 2026
vtab/vtabbar)
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Add standalone Tailwind vertical tab bar + preview (new
Refine vertical tab bar DnD UX: use global TabIndicator and add explicit insertion marker
Mar 2, 2026
vtab/vtabbar)Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Refine vertical tab bar DnD UX: use global TabIndicator and add explicit insertion marker
Polish vertical tab DnD UX: shared TabIndicator, no hover noise, stable drop marker layout
Mar 2, 2026
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Polish vertical tab DnD UX: shared TabIndicator, no hover noise, stable drop marker layout
Polish vertical tab DnD/controls UX: stable drop marker, left indicator, tooltip removal
Mar 2, 2026
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Polish vertical tab DnD/controls UX: stable drop marker, left indicator, tooltip removal
Polish vertical tab row layout: dynamic title width, precise close alignment, and tooltip/hover cleanup
Mar 2, 2026
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Polish vertical tab row layout: dynamic title width, precise close alignment, and tooltip/hover cleanup
Refine vertical tab layout density and add inline rename for left tabs
Mar 2, 2026
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Refine vertical tab layout density and add inline rename for left tabs
Fix left-tab drop indicator gap and align drag marker with divider
Mar 3, 2026
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Fix left-tab drop indicator gap and align drag marker with divider
Stabilize vertical-tab drag visuals: overlay drop marker + post-drop hover reset
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging in the vertical tab bar had two UX artifacts: the drop marker reserved layout space (leaving a visible accent gap above selected tabs), and hover styling could remain on the old row after drop until the mouse moved. This updates drag visuals to be overlay-based and forces hover recalculation at drag end.
Drop marker moved out of flow (no selected-tab accent gap)
offsetTop/offsetHeight) so it covers the divider location directly.Drop target rendering simplified
relative; marker is conditionally rendered only while reordering.dropLineTopis tracked during drag events and used to position the marker without affecting layout.Stale hover state cleared after drop
hoverResetVersion) and used it inVTabkeys.:hoveron the old index immediately.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.