Skip to content

Stabilize vertical-tab drag visuals: overlay drop marker + post-drop hover reset#2964

Draft
Copilot wants to merge 9 commits intomainfrom
copilot/create-vertical-tab-bar
Draft

Stabilize vertical-tab drag visuals: overlay drop marker + post-drop hover reset#2964
Copilot wants to merge 9 commits intomainfrom
copilot/create-vertical-tab-bar

Conversation

Copy link
Contributor

Copilot AI commented Mar 2, 2026

Dragging in the vertical tab bar had two UX artifacts: the drop marker reserved layout space (leaving a visible accent gap above selected tabs), and hover styling could remain on the old row after drop until the mouse moved. This updates drag visuals to be overlay-based and forces hover recalculation at drag end.

  • Drop marker moved out of flow (no selected-tab accent gap)

    • Replaced per-row in-flow divider placeholders with a single absolutely positioned drop line in the scroll container.
    • Drop line now aligns to actual tab boundaries (offsetTop / offsetHeight) so it covers the divider location directly.
  • Drop target rendering simplified

    • Container is relative; marker is conditionally rendered only while reordering.
    • dropLineTop is tracked during drag events and used to position the marker without affecting layout.
  • Stale hover state cleared after drop

    • Added a minimal drag-lifecycle reset mechanism (hoverResetVersion) and used it in VTab keys.
    • On drag end/drop, rows remount once, clearing browser-retained :hover on the old index immediately.
<VTab key={`${tab.id}:${hoverResetVersion}`} ... />

{dragTabId != null && dropIndex != null && dropLineTop != null && (
    <div
        className="pointer-events-none absolute left-0 right-0 border-t-2 border-accent/80"
        style={{ top: dropLineTop, transform: "translateY(-1px)" }}
    />
)}

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 2, 2026

Deploying waveterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 48919f6
Status: ✅  Deploy successful!
Preview URL: https://bd31d368.waveterm.pages.dev
Branch Preview URL: https://copilot-create-vertical-tab.waveterm.pages.dev

View logs

Copilot AI changed the title [WIP] Add vertical tab bar component for Wave Add standalone Tailwind vertical tab bar + preview (new vtab/vtabbar) Mar 2, 2026
Copilot finished work on behalf of sawka March 2, 2026 19:30
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot AI changed the title Add standalone Tailwind vertical tab bar + preview (new vtab/vtabbar) Refine vertical tab bar DnD UX: use global TabIndicator and add explicit insertion marker Mar 2, 2026
Copilot finished work on behalf of sawka March 2, 2026 20:12
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot AI changed the title Refine vertical tab bar DnD UX: use global TabIndicator and add explicit insertion marker Polish vertical tab DnD UX: shared TabIndicator, no hover noise, stable drop marker layout Mar 2, 2026
Copilot finished work on behalf of sawka March 2, 2026 20:29
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot AI changed the title Polish vertical tab DnD UX: shared TabIndicator, no hover noise, stable drop marker layout Polish vertical tab DnD/controls UX: stable drop marker, left indicator, tooltip removal Mar 2, 2026
Copilot finished work on behalf of sawka March 2, 2026 21:02
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot AI changed the title Polish vertical tab DnD/controls UX: stable drop marker, left indicator, tooltip removal Polish vertical tab row layout: dynamic title width, precise close alignment, and tooltip/hover cleanup Mar 2, 2026
Copilot finished work on behalf of sawka March 2, 2026 21:30
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot AI changed the title Polish vertical tab row layout: dynamic title width, precise close alignment, and tooltip/hover cleanup Refine vertical tab layout density and add inline rename for left tabs Mar 2, 2026
Copilot finished work on behalf of sawka March 2, 2026 23:40
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot AI changed the title Refine vertical tab layout density and add inline rename for left tabs Fix left-tab drop indicator gap and align drag marker with divider Mar 3, 2026
Copilot finished work on behalf of sawka March 3, 2026 01:39
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot AI changed the title Fix left-tab drop indicator gap and align drag marker with divider Stabilize vertical-tab drag visuals: overlay drop marker + post-drop hover reset Mar 3, 2026
Copilot finished work on behalf of sawka March 3, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants