hwcomposer/interfaces: Fix building on A14+#71
Open
supechicken wants to merge 1 commit into
Open
Conversation
522019e to
659c15b
Compare
There was a problem hiding this comment.
Code Review
This pull request updates WaydroidClipboard.cpp to remove const from std::vector elements and modifies WaydroidTask.cpp to support Android API level 34. A critical issue was identified in WaydroidTask.cpp where the use of a temporary String8 object results in a use-after-free vulnerability. Additionally, the fallback logic for empty application names was inadvertently omitted for the new API branch.
f19329d to
0190958
Compare
Signed-off-by: SupeChicken666 <me@supechicken666.dev>
0190958 to
7c499d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following errors: