Skip to content

Conversation

@vlodosmonkey
Copy link

Pull request guide

Thank you for considering to improve this cordova-plugin-googlemaps.

When you create a pull request, please make it to multiple_maps branch instead of master branch.

Because the multiple_maps branch is edge version.

Thank you for your understanding.

var countCluster = 0;
cluster._markerArray.forEach(function (marker) {
var data = marker.get('data');
if (data && data.data && data.data.operative == 'ECHARGE') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le pondria algo mas generico. Algo como

if (data && data.data && data.data.sumLabel) {
countCluster += data.data.label;
} else {
countCluster += 1;
}

Al meter el else ya no te hace falta el if de la linea 966

MarkerCluster.prototype.getClusterLabelData = function (self, data, key) {
var self = self;
var index = key.indexOf(".");
var firstPart = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cambiar la manera de acceder por esta manera, con un comentario a este enlace:

https://stackoverflow.com/questions/8051975/access-object-child-properties-using-a-dot-notation-string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants