Make singleNodeValue nullable to match DOM spec #55952
Merged
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the singleNodeValue attribute from non-nullable to nullable to match the DOM specification. Since null was already returned regardless of the IDL change, this patch is not an actual behavior change. Bug: 456874035 Change-Id: Ib6b69c8c991a6a21d531242c87bcdf4e51bc40ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7109180 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: YeongHan Kim <[email protected]> Reviewed-by: Jinho Bang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1542186}
wpt-pr-bot
approved these changes
Nov 8, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7109180
branch
from
85a5c64 to
39f98bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the singleNodeValue attribute from non-nullable to
nullable to match the DOM specification. Since null was already returned
regardless of the IDL change, this patch is not an actual behavior
change.
Bug: 456874035
Change-Id: Ib6b69c8c991a6a21d531242c87bcdf4e51bc40ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7109180
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: YeongHan Kim <[email protected]>
Reviewed-by: Jinho Bang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1542186}