fix: failed to parse bundle with IIFE #685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenstensberg
approved these changes
Dec 15, 2025
Member
|
@evenstensberg We need to add test cases |
alexander-akait
approved these changes
Dec 15, 2025
evenstensberg
approved these changes
Dec 15, 2025
valscion
approved these changes
Dec 16, 2025
Member
valscion
left a comment
valscion
left a comment
There was a problem hiding this comment.
Hmm yeah this might work but it looks like we would not be parsing any modules when this IIFE bundle is used? Is that expected?
Anyway, this looks good! Could you still add a changelog entry?
Member
|
@valscion In this case there are no modules, anyway in our TODOs to add all test cases for ES modules with and without IIFE, it is just an edge case |
Member
|
Yeah that's true. I'll add a changelog entry myself when I have the time or then @hai-x can add one — I'll merge once the changelog is there and release when I have a good slot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce?
Fixes #684, #409.
Did you add tests for your changes?
It seems we currently don’t support parsing top-level chunk modules and i’m also not sure whether parsing is the right approach for get rendered chunk modules.
e.g.
So i add one simple IIFE case here without chunk modules.
Here is test result before fixing:
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No