feat(home): add custom feature-section icons#191
Open
ryzrr wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
reviewed
Jul 18, 2026
Comment on lines
+99
to
+106
| export { | ||
| ModuleFederation, | ||
| CodeSplitting, | ||
| TreeShaking, | ||
| HotModuleReplacement, | ||
| PersistentCaching, | ||
| Plugins, | ||
| }; |
Member
There was a problem hiding this comment.
nit: inline exports (e.g. export const
| @@ -0,0 +1,106 @@ | |||
| const Svg = ({ children, ...props }) => ( | |||
Member
There was a problem hiding this comment.
Suggested change
| const Svg = ({ children, ...props }) => ( | |
| const Icon = ({ children, ...props }) => ( |
Let's be a bit more descriptive
Member
There was a problem hiding this comment.
I wonder if we can replace these with an icon library, for instance,
Lucide:
- Module Federation: https://lucide.dev/icons/waypoints
- Code Splitting: https://lucide.dev/icons/network, https://lucide.dev/icons/split,
- Tree Shaking: https://lucide.dev/icons/trees
- HMR: https://lucide.dev/icons/refresh-ccw-dot
- Caching: https://lucide.dev/icons/database-zap
- Plugins: https://lucide.dev/icons/puzzle, https://lucide.dev/icons/plug, https://lucide.dev/icons/toy-brick
Member
Author
There was a problem hiding this comment.
My only concern were licensing , if it is okay , we can use the above icons
Member
There was a problem hiding this comment.
It should be fine. Lucide bundles it's license into it's source code
Member
Author
There was a problem hiding this comment.
okay, replacing the icon with lucide
avivkeller
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce?
Icons fix
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
NA
Use of AI
Yes for Designing