Fix data dimension swapping and axis errors#1335
Open
abhayrajjais01 wants to merge 2 commits intoweecology:mainfrom
Open
Fix data dimension swapping and axis errors#1335abhayrajjais01 wants to merge 2 commits intoweecology:mainfrom
abhayrajjais01 wants to merge 2 commits intoweecology:mainfrom
Conversation
Contributor
|
Hi @abhayrajjais01,
|
Contributor
Author
Hi @vickysharma-prog,
|
abhayrajjais01
force-pushed
the
fix-data-dimensions
branch
from
e11fa34 to
bde5364
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1335 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 24 24
Lines 2978 2978
=======================================
Hits 2601 2601
Misses 377 377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henrykironde
reviewed
Mar 9, 2026
| assert ds[1].shape == (3, 300, 300) | ||
|
|
||
|
|
||
| def test_TiledRaster_non_square(tmp_path): |
Contributor
There was a problem hiding this comment.
I’m having difficulty seeing how this test is necessary given the changes made.
henrykironde
reviewed
Mar 9, 2026
| # Check that it's 3 bands | ||
| bands = numpy_image.shape[2] | ||
| # Check that it's 3 bands (image is now channels-first: C x H x W) | ||
| bands = numpy_image.shape[0] |
Contributor
There was a problem hiding this comment.
Please take some time to understand this part of the code, you may be able to make more meaningful improvements to the logic.
henrykironde
requested changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two dimensionality and shape bugs when preparing and loading data for predictions.
Changes:
src/deepforest/datasets/prediction.py: Fixed a bug whereheightandwidthbounds were swapped when passed toslidingwindow.generateForSize.rasterio'ssrc.shapereturns(height, width), but the variables were passed to the generator in reversed order.src/deepforest/preprocess.py: Fixed a bug wherenumpy_image.shape[2]was being accessed for the number of bands after the image tensor was already transposed from(H, W, C)to channels-first(C, H, W). It now correctly checksnumpy_image.shape[0].Type of change
AI-Assisted Development
AI tools used (if applicable):
Gemini