This repository was archived by the owner on Apr 16, 2021. It is now read-only.
Fix 400 error on mfa authentication#90
Open
k3an3 wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks @k3an3 for the PR. What kind of garbage data is excluded? |
Contributor
Author
|
If you don't include nonzero=True, the positions returned includes (all?) historic options positions where the quantity == 0. So if I run it the default way, I get my current open positions (which is only a few entries), and then basically every single other position I've ever had. It seems slower to pull all of this data, and I don't think it is necessary unless you are specifically trying to go back and look at all of your historic options. This fix just saves you from filtering by positions with quantity != 0 |
|
I've found that I need to include X-ROBINHOOD-CHALLENGE-RESPONSE-ID to the headers to resolve the 400 issue. |
Owner
Owner
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web API uses
device_tokenas one of the fields during authentication. Looking at the issues for this and other similar API clients, people have been generating these randomly but it can also be done by the standarduuidlibrary.Without this change, I get this error calling
Client.authenticate():requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.robinhood.com/oauth2/token/Second, the API also takes a
nonzeroparameter when fetching all options positions. Thought it was nice to include this since you don't get as much garbage data this way. Could even make this the default option if so inclined.