fix(Hex): throw on empty hex in toNumber instead of returning NaN#275
Open
spokodev wants to merge 1 commit into
Open
fix(Hex): throw on empty hex in toNumber instead of returning NaN#275spokodev wants to merge 1 commit into
spokodev wants to merge 1 commit into
Conversation
|
@spokodev is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hex.toNumber('0x')returnsNaN, whileHex.toBigInt('0x')throws.The no-options fast path decodes via
Number(hex), andNumber('0x')isNaN, so empty hex silently yields a non-number instead of erroring. viem'shexToNumberroutes throughhexToBigIntand throws here;Bytes.toNumber(which delegates toHex.toNumber) is affected too.The fix keeps the fast path for valid hex and only defers to
toBigIntwhenNumber(hex)isNaN. For all valid hex,Number(hex) === Number(toBigInt(hex));0xis the only divergence, so no valid result changes.Added a regression test asserting
Hex.toNumber('0x')throws.