Repository navigation
fix: build native addons for every napi target and link Linux glibc addons against glibc 2.17 - #450
Conversation
…ddons against glibc 2.17 Releases published only the linux-x64-gnu addon, built against the runner's glibc 2.39, so it failed to load below glibc 2.35 and every other platform fell back to WASI. The Binding workflow now builds each native target on a matching runner (musl inside Alpine), loads each addon, and loads the glibc addons on Debian 11. The release job downloads every addon into `binding/`, and `check:binding` fails the publish when one is missing. `scripts/build-binding.ts` takes `--target` and links `-linux-gnu` targets with the `@napi-rs/cross-toolchain` glibc 2.17 sysroot. Fixes #449 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcBWWdnfcnphvx9aMkiGuH
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
napi-rs sets `aarch64-linux-musl-gcc` as the aarch64-unknown-linux-musl linker even on an aarch64 musl host, where Alpine provides only `cc`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcBWWdnfcnphvx9aMkiGuH
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad3880b47c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
`scripts/train-binding.ts` loaded the first `.node` file in `binding/`, which could be another platform's addon. The build now passes the instrumented addon's path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcBWWdnfcnphvx9aMkiGuH
|
|
commit: |
Fixes #449.
Releases shipped only
zyzz.linux-x64-gnu.node, built against the runner's glibc 2.39. It failed to load below glibc 2.35 (Vercel, Amazon Linux 2023, Debian 11), and macOS, Windows, and Linux arm64 fell back to WASI.scripts/build-binding.tstakes--target <triple>and links-linux-gnutargets with--use-napi-cross(glibc 2.17 sysroot), keeping PGO.main.ymlruns the matrix only for a version npm lacks, downloads every addon intobinding/, andpnpm check:bindingfails the publish when one is missing.All addons ship in the
zyzztarball (about 12.6 MB raw, 5.2 MB gzip each). Per-platform@zyzz/binding-*packages stay in.agents/plan.md.Validation: the x64 glibc PGO build loads on the host and in
node:22-bullseye-slim, the x64 musl PGO build loads innode:24-alpine, andpnpm check:typesandpnpm checkpass. This PR's Binding run covers the macOS, Windows, and arm64 targets.🤖 Generated with Claude Code
https://claude.ai/code/session_01PcBWWdnfcnphvx9aMkiGuH
Generated by Claude Code