Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #528: this branch includes its commit. Review only the last commit, and merge after #528.
zyzz/esbuildfails underBun.buildwithbuild.resolve() is not implemented yet(oven-sh/bun#2771). Unplugin 3 has a Bun target, sozyzz.bun(alsozyzzfromzyzz/bun) wraps it and resolves throughBun.resolveSync, honoringexternal. It requiresoutdir, and the scan skips it.Bun lowers
light-dark()in bundled package CSS to--buncss-lightand--buncss-darkand sets them only beside thecolor-schemedeclarations it compiles. Without a fallback, every such color dropped.zyzz.cssfrom Bun ends with:where(:root){--buncss-light:initial;--buncss-dark: }, which selects the light value, aslight-dark()does by default.vite build(with #527)bun build.tswithzyzz/bun, whole processBun output renders pixel-identical to the Vite build in light and dark schemes.
Validation: new
bun resolves installed packages and emits stylesheetsscenario,tsc, and the same suites (212 tests) pass. CI installs Bun in the test job (oven-sh/setup-bunpinned to v2.2.0).