Skip to content

Conversation

@RDruon
Copy link
Contributor

@RDruon RDruon commented Mar 19, 2025

See new fixture and look for negative value

write                     186442470 samples [usecs] 36 149845092510 -823495890607571055 4426400394686790401

We handle this by ignoring them

@RDruon RDruon self-assigned this Mar 19, 2025
@RDruon RDruon requested a review from jgrund as a code owner March 19, 2025 11:03
@notion-workspace
Copy link

@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (fe11f85) to head (a721d39).

Files with missing lines Patch % Lines
lustre-collector/src/base_parsers.rs 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   91.77%   91.80%   +0.03%     
==========================================
  Files          41       41              
  Lines        5225     5262      +37     
  Branches     5225     5262      +37     
==========================================
+ Hits         4795     4831      +36     
- Misses        394      395       +1     
  Partials       36       36              
Flag Coverage Δ
2_14_0_ddn133 35.26% <47.16%> (-0.01%) ⬇️
2_14_0_ddn145 36.01% <47.16%> (-0.01%) ⬇️
all-tests 91.80% <96.22%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Benchmark for b108022

Click to view benchmark
Test Base PR %
jobstats 100 3.8±0.57ms 3.7±0.53ms -2.63%
jobstats 1000 36.1±4.59ms 37.1±5.39ms +2.77%

@github-actions
Copy link

Benchmark for 2c81333

Click to view benchmark
Test Base PR %
jobstats 100 4.1±0.70ms 4.2±0.73ms +2.44%
jobstats 1000 39.3±6.55ms 39.1±5.83ms -0.51%

@github-actions
Copy link

Benchmark for 3169aa1

Click to view benchmark
Test Base PR %
jobstats 100 3.9±0.51ms 3.7±0.51ms -5.13%
jobstats 1000 38.0±4.75ms 38.8±5.25ms +2.11%

@github-actions
Copy link

Benchmark for 1f56308

Click to view benchmark
Test Base PR %
jobstats 100 3.9±0.62ms 3.8±0.60ms -2.56%
jobstats 1000 37.7±5.32ms 36.1±4.31ms -4.24%

@github-actions
Copy link

Benchmark for 4362328

Click to view benchmark
Test Base PR %
jobstats 100 4.0±0.65ms 3.7±0.56ms -7.50%
jobstats 1000 39.1±5.05ms 36.2±3.94ms -7.42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants