Editorial: clarify document argument of "clone a node" #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This argument is only passed recursively or from importNode(). And importNode() does not work for documents, so whenever the node argument is a document, the document argument has to be the node argument.
dbaron
reviewed
Dec 12, 2024
Member
dbaron
left a comment
dbaron
left a comment
There was a problem hiding this comment.
This seems fine except for one thing (below).
| <dd><p>Do nothing. | ||
| </dl> | ||
|
|
||
| <li><p>Set <var>copy</var>'s <a for=Node>node document</a> and <var>document</var> to |
Member
There was a problem hiding this comment.
Wasn't this text needed to make a cloned document have the right node document (itself, not the document it was cloned from)?
Member
Author
There was a problem hiding this comment.
Thanks, that's indeed what it was for. Should be good now (and hopefully clearer too).
Member
There was a problem hiding this comment.
Yes, agree the new version is clearer.
dbaron
approved these changes
Dec 12, 2024
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 3, 2025
Main difference is that a chunk of the "clone a node" steps are pulled out into a "clone a single node" algorithm. Reflects these spec PRs: whatwg/dom#1332 whatwg/dom#1334 Though this code is quite old so there may also be older spec changes included here.
tcl3
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Jan 4, 2025
Main difference is that a chunk of the "clone a node" steps are pulled out into a "clone a single node" algorithm. Reflects these spec PRs: whatwg/dom#1332 whatwg/dom#1334 Though this code is quite old so there may also be older spec changes included here.
pbrw
pushed a commit
to pbrw/ladybird
that referenced
this pull request
Jan 14, 2025
Main difference is that a chunk of the "clone a node" steps are pulled out into a "clone a single node" algorithm. Reflects these spec PRs: whatwg/dom#1332 whatwg/dom#1334 Though this code is quite old so there may also be older spec changes included here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument is only passed recursively or from importNode(). And importNode() does not work for documents, so whenever the node argument is a document, the document argument has to be the node argument.
(I want to fix the other aspects of this algorithm too. But I thought I'd make this in isolation while I spotted it.)