-
Notifications
You must be signed in to change notification settings - Fork 229
Bump minitest dependency #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is very broken, possibly due to the Minitest update itself. |
c98ba96 to
485072a
Compare
485072a to
d86a2ea
Compare
d86a2ea to
0b15ceb
Compare
etagwerker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faisal Looks good, thanks! 👍🏻
1fe3c0c to
0e7318a
Compare
|
I've now squashed this back to one commit again. Note: Minitest is now on to 6.0. We can update to that once minitest-around works with it or we stop needing minitest-around. |
|
With splattael/minitest-around#40, I hope the next release of minitest-around works with Minitest 6. We're poking at some CI issues on that gem first, though. |
|
CI issues resolved. Waiting on an updated release. |
0e7318a to
d3bcd9e
Compare
- Bump minitest to 5.2.7 (the last compatible with Ruby 3.1.x)
d3bcd9e to
4609fbc
Compare
|
Minitest 6.0 requires Ruby 3.2, so I'll update to that as part of the Ruby 3.2 PR. Assuming the latest test run is green I think this should be ready to merge. |
|
@etagwerker Did you want to cut one final release to restore Ruby 3.1 compatibility (branching before the 3.1 EOL commit)? If so, do you want to pick this up in the branch? If the answer isn't yes to both of those, I can close this out. |
|
@faisal Yes, that sounds like a good idea. 👍🏻 |
Minitest is moving forward. This is the last 5.x version.
Check list: