Merged
Conversation
daniel-zint
requested changes
Mar 16, 2026
Contributor
daniel-zint
left a comment
daniel-zint
left a comment
There was a problem hiding this comment.
Looks decent. I left a few minor comments. Integration tests are missing, though.
components/image_simulation/wmtk/components/image_simulation/ImageSimulationMeshTri.cpp
Outdated
Show resolved
Hide resolved
...nts/image_simulation/wmtk/components/image_simulation/ConnectedComponentAnnotationHelper.inl
Outdated
Show resolved
Hide resolved
| "DEBUG engulf_components: face row {} (verts [{},{},{}]) " | ||
| "has near-zero area = {} | pos [{},{}] [{},{}] [{},{}]", | ||
| i, | ||
| F(i, 0), |
Contributor
There was a problem hiding this comment.
You can directly print Eigen Vectors with fmt, e.g., F.row(i). That should help make this code a bit cleaner.
Also, is this still needed? Looks like it's just debug output.
Collaborator
Author
There was a problem hiding this comment.
Yeah, this was indeed DEBUG code, but I left it, as it serves as a good integration test too. Will keep it around for these dev days, and remove once it works well for a larger range of examples.
...nts/image_simulation/wmtk/components/image_simulation/ConnectedComponentAnnotationHelper.inl
Outdated
Show resolved
Hide resolved
...nts/image_simulation/wmtk/components/image_simulation/ConnectedComponentAnnotationHelper.inl
Outdated
Show resolved
Hide resolved
components/image_simulation/wmtk/components/image_simulation/image_simulation.cpp
Outdated
Show resolved
Hide resolved
components/image_simulation/wmtk/components/image_simulation/image_simulation.cpp
Outdated
Show resolved
Hide resolved
components/image_simulation/wmtk/components/image_simulation/ImageSimulationMeshTri.cpp
Show resolved
Hide resolved
components/image_simulation/wmtk/components/image_simulation/ImageSimulationMeshTri.hpp
Show resolved
Hide resolved
components/image_simulation/wmtk/components/image_simulation/ImageSimulationMeshTri.hpp
Outdated
Show resolved
Hide resolved
daniel-zint
approved these changes
Mar 18, 2026
Contributor
daniel-zint
left a comment
daniel-zint
left a comment
There was a problem hiding this comment.
Looks great! Just one comment on namespaces. Not a big deal, though, if you leave it like that.
...nts/image_simulation/wmtk/components/image_simulation/ConnectedComponentAnnotationHelper.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill Holes
Keep Largest Connected Component
Tight Seal with Marching