You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is meant as proof of concept and does not fix WINDUPRULE-1046
One problem is, that windup-cli --openrewrite uses -Drewrite.recipeArtifactCoordinates but this option apparently doesn't understand maven classifiers.
Also it might not be the best solution to generate a separate artifact instead of just moving the rewrite.yml files to META-INF/rewrite. However that would have more impact, while this change is compatible with older versions.
Thanks for this @ErhardSiegl - this is a really good idea and I'll have a think about whether it's best to create the jar or just move the recipes to META-INF/rewrite. Does openrewrite automatically parse any yaml files under there? Or do they have to be named rewrite.yml? I'm just thinking of the logistics of moving several files with the same name to the same folder.
Ah, I think I get it - Does what you suggest here do it by maintaining the existing directory structure under META-INF/rewrite and openrewrite picks up all rewrite.yml files under that top folder?
The files don't have to be named rewrite.yml. Many projects use different names (see e.g. Quarkus) and have it directly under META-INF/rewrite.
Indeed, in my example the directory structure is maintained to avoid conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a contribution to https://issues.redhat.com/browse/WINDUPRULE-1046
It enables to use the following plugin configuration in
pom.xmland then e.g:
The code is taken from https://github.com/quarkusio/quarkus-updates/blob/main/recipes/pom.xml and https://github.com/quarkusio/quarkus-updates/blob/main/recipes/src/main/assembly/core.xml
This is meant as proof of concept and does not fix WINDUPRULE-1046
One problem is, that
windup-cli --openrewriteuses-Drewrite.recipeArtifactCoordinatesbut this option apparently doesn't understand maven classifiers.Also it might not be the best solution to generate a separate artifact instead of just moving the
rewrite.ymlfiles toMETA-INF/rewrite. However that would have more impact, while this change is compatible with older versions.