build: add manually triggered release workflow [WPB-21384]#1914
Merged
coriolinus merged 3 commits intomainfrom Mar 9, 2026
Merged
build: add manually triggered release workflow [WPB-21384]#1914coriolinus merged 3 commits intomainfrom
coriolinus merged 3 commits intomainfrom
Conversation
typfel
force-pushed
the
simon/ci/stage-jvm-android-before-publish-WPB-22853
branch
2 times, most recently
from
7ae24a6 to
6f07736
Compare
Base automatically changed from
simon/ci/stage-jvm-android-before-publish-WPB-22853
to
main
March 6, 2026 10:33
coriolinus
force-pushed
the
prgn/build/21384-manually-triggered-release
branch
from
b9103b6 to
3fd0bc9
Compare
|
|
||
| - name: download artifacts | ||
| id: download | ||
| if: ${{ inputs.prepare == false && inputs.release == true }} |
Member
There was a problem hiding this comment.
What do you think about doing
${{ inputs.prepare != true && inputs.release == true }} instead? So we don't need to pass both arguments on the call sites when releasing.
Contributor
Author
There was a problem hiding this comment.
Doesn't the default: false in the variable definition cover that?
SimonThormeyer
approved these changes
Mar 6, 2026
Member
SimonThormeyer
left a comment
SimonThormeyer
left a comment
There was a problem hiding this comment.
On potential nit left. Let's try it out (when we get to).
If we're doing a release, the artifacts should already exist on sonatype, and we don't need a rebuild.
This makes it possible to gracefully recover from a partial/failed release by reattempting with existing artifacts.
We now explicitly prepare the NPM tarball and upload it to the release page at the same time as preparing the JVM/Android artifacts. Then, releasing is just a matter of downloading/releasing the pre-published file, not building anything. This better aligns with the intent of our release process.
coriolinus
force-pushed
the
prgn/build/21384-manually-triggered-release
branch
from
1d817d3 to
5a7b485
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Adds manual workflow to reattempt release.
DO NOT MERGE BEFORE #1875
Note for NPM: someone with appropriate access will need to update the trusted publishers settings and add the
publishworkflow; I do not have that access.PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.