fix(printer): match Prettier's HTML printer - #474
Merged
Conversation
🦋 Changeset detectedLatest commit: b6080b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… multi-child containers
Princesseuh
force-pushed
the
fix/html-mode-preserve-breaks
branch
from
August 19, 2026 01:59
1b73f32 to
6639413
Compare
Princesseuh
marked this pull request as ready for review
September 4, 2026 14:48
Princesseuh
commented
Sep 4, 2026
Princesseuh
commented
Sep 4, 2026
ematipico
reviewed
Sep 4, 2026
ematipico
left a comment
ematipico
left a comment
Member
There was a problem hiding this comment.
Unfortunately I don't much about this part of the code. I left only a few nits
ematipico
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier's HTML formatting has a lot of quirk and edges on various constructs that we weren't properly copying when in HTML mode. A lot of the code here is essentially Prettier's HTML formatting utils modified to suit our AST and Astro-constructs in general.