(0.15.x backport) Hostname creation cleanup, avoid that default DNS name ESP-xxxxx gets used#5436
Open
softhack007 wants to merge 2 commits into0_15_xfrom
Open
(0.15.x backport) Hostname creation cleanup, avoid that default DNS name ESP-xxxxx gets used#5436softhack007 wants to merge 2 commits into0_15_xfrom
softhack007 wants to merge 2 commits into0_15_xfrom
Conversation
… used (#5424) Bug Fixes * Improved hostname sanitization and buffer-size safeguards to prevent truncation and ensure DNS-compliant names. * Hostname is now applied earlier during network setup and on reconnects (ESP32), improving connectivity and ensuring settings take effect. * Solves the problem that ESP32 boards show as "ESP-xxxxxx" on the network, no matter if DNS name is defined or not * (breaking fix) prevent hostnames with double ``WLED-`` prefix, like ``wled-WLED-kitchen`` New Features * Added a length-aware hostname retrieval API with an mDNS-preference option and robust fallback behavior. * Preserved legacy compatibility by providing a length-aware alias for legacy hostname preparation. Open Ends * mDNS name is not sanitized when registering the mDNS endpoint, to avoid breaking previous functionality
* preserve old method for device name creation, allowing double names like WLED-wled-Kitchen * only prefer mDNS name at startup (fixes #5424)
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
New Features
Limitations
WLED-prefix, likewled-WLED-kitchenstill allowed, to prevent breaking legacy behaviourSummary by CodeRabbit