Conversation
To reject F/325 as false positive
There was a problem hiding this comment.
Pull request overview
This PR addresses issues reported by Fenrir around socket “connection” semantics: ensuring UDP connected sockets only accept datagrams from the connected peer, and tightening TCP 3-way handshake validation before transitioning to TCP_ESTABLISHED.
Changes:
- Fix UDP receive-side socket matching to enforce connected-peer source IP filtering.
- Add additional TCP sequence/acknowledgement validation in
SYN_SENT/SYN_RCVD, plus stricter RST handling. - Update and extend unit tests to cover the new UDP/TCP behaviors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/wolfip.c |
Updates UDP demux rules for connected sockets; adds TCP handshake ACK/SEQ checks and RST sequence validation logic. |
src/test/unit/unit.c |
Adjusts existing tests for new handshake expectations and adds new tests for invalid SYN-ACK ACK rejection, RST handling, and UDP connected wrong-source rejection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
F/392
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.